Review main Merged

36700[BUGFIX] Properly check type of POST vars on clipboard action

Markus Klein CR +2 V +2 Easy +2 −2 updated 02/06/15, 12:41

Commit message

Avoid a PHP warning by checking the type of data retrieved via POST.

"CBC" is an array of checkboxes, which can be null if nothing is selected.
"CBH" is an array of hidden fields. If this is not an array, something
is messed up in HTML generation and an Exception should be thrown then
(because of a PHP warning).

Also adapt the list module code accordingly.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Markus Klein +1
  • Verified V +2
    • Helmut Hummel +2
    • Markus Klein +1

Issues 1

Files 2

Review log 15

  1. Markus Klein uploaded patch set 1 02/05/15, 23:48

  2. Markus Klein updated the commit message in patch set 2 02/05/15, 23:50

  3. Helmut Hummel voted on patch set 2 CR +2 02/06/15, 08:52

  4. Frederic Gaus voted on patch set 2 CR +1 02/06/15, 11:33

  5. Oliver Klee voted on patch set 2 CR +1 02/06/15, 11:42

  6. Helmut Hummel commented on patch set 2 CR -1 02/06/15, 11:46

    oops, I have to revert my +2 there is a typo
  7. Helmut Hummel commented on patch set 2 02/06/15, 11:46

    FileListController.php:287

    Must be GeneralUtility::_POST('CBC') here!!
  8. Helmut Hummel voted on patch set 2 V -1 02/06/15, 11:47

  9. Markus Klein commented on patch set 2 02/06/15, 12:04

    *ROFL* Still the clipboard worked
  10. Markus Klein uploaded patch set 3 02/06/15, 12:06

  11. Helmut Hummel commented on patch set 3 CR -1 02/06/15, 12:15

    Hm, your comment about "the clipboard still worked" made me sceptical and I looked in to the code that produces the CBC/CBH POST arguments. As far as I can see, *both* are always present. So the real question is: why aren't they in your case? I'll try to reproduce.
  12. Helmut Hummel uploaded patch set 4 02/06/15, 12:35

  13. Helmut Hummel voted on patch set 4 CR +2 V +2 02/06/15, 12:36

  14. Markus Klein voted on patch set 4 CR +1 V +1 02/06/15, 12:40

  15. Helmut Hummel merged patch set 4 02/06/15, 12:41