36700[BUGFIX] Properly check type of POST vars on clipboard action
Commit message
Review
-
Code review CR +2
- Helmut Hummel +2
- Markus Klein +1
-
Verified V +2
- Helmut Hummel +2
- Markus Klein +1
Issues 1
Files 2
Review log 15
-
Markus Klein uploaded patch set 1 02/05/15, 23:48
-
Markus Klein updated the commit message in patch set 2 02/05/15, 23:50
-
Helmut Hummel voted on patch set 2 CR +2 02/06/15, 08:52
-
Frederic Gaus voted on patch set 2 CR +1 02/06/15, 11:33
-
Oliver Klee voted on patch set 2 CR +1 02/06/15, 11:42
-
Helmut Hummel commented on patch set 2 CR -1 02/06/15, 11:46
oops, I have to revert my +2 there is a typo -
Helmut Hummel commented on patch set 2 02/06/15, 11:46
FileListController.php:287Must be GeneralUtility::_POST('CBC') here!! -
Helmut Hummel voted on patch set 2 V -1 02/06/15, 11:47
-
Markus Klein commented on patch set 2 02/06/15, 12:04
*ROFL* Still the clipboard worked -
Markus Klein uploaded patch set 3 02/06/15, 12:06
-
Helmut Hummel commented on patch set 3 CR -1 02/06/15, 12:15
Hm, your comment about "the clipboard still worked" made me sceptical and I looked in to the code that produces the CBC/CBH POST arguments. As far as I can see, *both* are always present. So the real question is: why aren't they in your case? I'll try to reproduce. -
Helmut Hummel uploaded patch set 4 02/06/15, 12:35
-
Helmut Hummel voted on patch set 4 CR +2 V +2 02/06/15, 12:36
-
Markus Klein voted on patch set 4 CR +1 V +1 02/06/15, 12:40
-
Helmut Hummel merged patch set 4 02/06/15, 12:41