Review main Merged

36720[BUGFIX] Cleaner scripts crashes due to incomplete flexform content

Jose Antonio Guerra CR +2 V +2 Normal +94 −6 updated 03/12/15, 19:57

Commit message

Failure to check arguments used on recursive function call
causes PHP runtime error.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Mathias Schreiber +1
  • Verified V +2
    • Christian Kuhn +2
    • Mathias Schreiber +1

Issues 1

Files 2

Review log 11

  1. Jose Antonio Guerra uploaded patch set 1 02/06/15, 18:34

  2. Mathias Schreiber updated the commit message in patch set 2 02/06/15, 18:40

  3. Christian Kuhn commented on patch set 2 CR -1 02/06/15, 18:45

    cool. thanks for pushing a patch for this so quickly, especially with added test coverage. I'll do some minor cleanups like indenting and will give the patch a shot now.
  4. Christian Kuhn uploaded patch set 3 02/06/15, 19:05

  5. Christian Kuhn uploaded patch set 4 02/06/15, 19:08

  6. Christian Kuhn voted on patch set 4 CR +1 V +1 02/06/15, 19:09

  7. Mathias Schreiber commented on patch set 4 CR +1 V +1 02/06/15, 19:35

    good to see you back, Jose :)
  8. Christian Kuhn voted on patch set 4 CR +2 V +2 02/06/15, 19:41

  9. Christian Kuhn merged patch set 4 02/06/15, 19:41

  10. Christian Kuhn commented on patch set 5 02/06/15, 19:42

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 7954637e86062ee4120eb64edd3a97ed86618c83
  11. Markus Klein commented on patch set 5 03/12/15, 19:57

    post -1

    FlexFormTools.php:230

    breaking change! callbacks now get an array instead of multiple parameters