Review TYPO3_6-2 Merged

36722[BUGFIX] Cleaner scripts crashes due to incomplete flexform content

Christian Kuhn CR +2 V +2 Normal +93 −5 updated 03/12/15, 21:11

Commit message

Failure to check arguments used on recursive function call
causes PHP runtime error.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 2

Review log 7

  1. Christian Kuhn voted on patch set 1 CR -1 02/06/15, 19:42

  2. Christian Kuhn commented on patch set 1 02/06/15, 19:42

    ::class needs to be resolved for 6.2 ... i'll push update.
  3. Christian Kuhn uploaded patch set 2 02/06/15, 19:45

  4. Christian Kuhn commented on patch set 2 02/06/15, 19:48

    travis running for this one at https://travis-ci.org/lolli42/TYPO3.CMS-Catharsis/builds/49784973 - just in case i was too stupid and missed something ;)
  5. Christian Kuhn voted on patch set 2 CR +2 V +2 02/06/15, 19:54

  6. Christian Kuhn merged patch set 2 02/06/15, 19:54

  7. Jo Hasenau commented on patch set 3 03/12/15, 21:11

    According to a clients information the import of the l10nmgr is broken with 6.2.10 and I tracked it down to this change. The problem is the new behavour in line 225 of FlexFormTools.php The old version handed over $this as reference, the new one puts it into an array Results in PHP Warning: Parameter 5 to tx_l10nmgr_tools::translationDetails_flexFormCallBackForOverlay() expected to be a reference, value given in /domains/typo3_src/typo3_src-6.2.10/typo3/sysext/core/Classes/Configuration/FlexForm/FlexFormTools.php line 242