Review TYPO3_6-2 Merged

36727[BUGFIX] Update misleading help text about deprecated/removed features

Michael Schams CR +2 V +2 Easy +8 −8 updated 09/26/15, 17:26

Commit message

This patch corrects misleading help texts about deprecated curl*
functions such as curlProxyServer, curlProxyTunnel, curlProxyUserPass and
curlTimeout. The texts claim, these settings have been removed in 6.2,
which is not true (they are still used and required).

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 16

  1. Michael Schams uploaded patch set 1 02/07/15, 13:54

  2. Markus Klein commented on patch set 1 02/07/15, 14:53

    Please leave the deprecated message. just remove the "will be removed part"
  3. Philipp Gampe commented on patch set 1 02/07/15, 17:31

    IMHO needs to go into master (7) too.
  4. Stefan Neufeind commented on patch set 1 CR -1 02/07/15, 17:39

    We can't remove it in 6.2.x anymore. So imho let's update the message to "removed in CMS 7" and make sure there is a followup-issue (or even provide a patch) so we don't forget to clean up the situation in the master-branch.
  5. Michael Schams commented on patch set 1 02/11/15, 07:04

    We cant remove the functionality in 6.2, but we should update the (misleading) help text - because it's simply wrong. I created a follow-up ticket, but nobody can guarantee that this will be completed in 7. This is why I suggested the text "This setting is deprecated - see alternative options in section HTTP" in patch set 1 and did not mention when it will be removed. Not ok?
  6. Markus Klein commented on patch set 1 02/11/15, 07:24

    Do we actually have a full replacement for those options? If not, we should remove the deprecation notice completely!
  7. Michael Schams commented on patch set 1 02/12/15, 00:14

    My frustration is, that admins have to configure HTTP proxy settings at two(!) places at the moment, see links/discussions at #64978. This leads to confusion, which could be addressed by classifying one option (the curl* settings) as deprecated (which officially is since 4.6) and encourage devs to use the other one. Withdrawing the deprecation notice would be a step backwards from my perspective.
  8. Michael Schams commented on patch set 1 02/20/15, 06:17

    Looks like we've got two or three different opinions here :-) How do we proceed?
  9. Christian Kuhn commented on patch set 1 03/04/15, 20:12

    imho - lets change the text to "will be removed with 7" in 6.2 branch ... for master we should then really take care that the last bits of this stuff are finally resolved.
  10. Christian Kuhn commented on patch set 1 03/04/15, 20:14

    i'll add this to my todo list and will come up with something if nobody else does until 7 lts ...
  11. Wouter Wolters uploaded patch set 2 03/04/15, 20:18

  12. Christian Kuhn voted on patch set 2 CR +1 V +1 03/04/15, 20:21

  13. Wouter Wolters voted on patch set 2 V +2 CR +2 03/04/15, 20:22

  14. Wouter Wolters merged patch set 2 03/04/15, 20:22

  15. Nicole Hummel commented on patch set 3 09/26/15, 16:09

    Any reason this one was merged in 6.2 but not in master (7)?
  16. Markus Klein commented on patch set 3 09/26/15, 17:26

    Because it was targeted for removal in 7 anyway. But that's different again now, obviously.