Review main Merged

36765[BUGFIX] Cygwin support

Frederic Gaus CR +2 V +2 Easy +1 −1 updated 03/15/15, 16:10

Commit message

Cygwin is a GNU UNIX emulation layer for Windows systems.
With this patch the TYPO3 OS detection will recognize when
running on cygwin and thus TYPO3_OS won't be defined as 'WIN'.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Stefan Neufeind +1
    • Stephan Großberndt +1
    • Markus Klein +1
  • Verified V +2
    • Frank Nägler +2
    • Markus Klein +1

Issues 1

Files 1

Review log 10

  1. Frederic Gaus uploaded patch set 1 02/09/15, 10:55

  2. Markus Klein updated the commit message in patch set 2 02/09/15, 11:08

  3. Markus Klein commented on patch set 2 02/09/15, 11:09

    Maybe even a small FEATURE IMHO: Target is 7.2+
  4. Markus Klein voted on patch set 2 CR +1 02/09/15, 11:09

  5. Stephan Großberndt voted on patch set 2 CR +1 02/12/15, 00:17

  6. Stefan Neufeind commented on patch set 2 CR +1 02/16/15, 12:36

    Don't have a cygwin to test. But I expect you did. Sounds like a valid approach, given that Cygwin is used to emulate unix-behaviour (and does not behave like Win then).
  7. Stefan Neufeind commented on patch set 2 02/16/15, 12:38

    I'd see it as a fix - just like darwin != win it's cygwin != win here.
  8. Markus Klein commented on patch set 2 V +1 03/10/15, 22:56

    lets get that in
  9. Frank Nägler commented on patch set 2 V +2 CR +2 03/15/15, 16:10

    verified by code-review
  10. Frank Nägler merged patch set 2 03/15/15, 16:10