Review main Merged

36776[BUGFIX] Replace deprecated Fluid methods in Install Tool

Andreas Kienast CR +2 V +2 Easy +2 −2 updated 02/09/15, 17:10

Commit message

Replace the deprecated methods setLayoutRootPath() and setPartialRootPath().

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Nicole Hummel +1
  • Verified V +2
    • Christian Kuhn +2
    • Nicole Hummel +1

Issues 1

Files 1

Review log 6

  1. Andreas Kienast uploaded patch set 1 02/09/15, 16:15

  2. Andreas Kienast wrote 02/09/15, 16:18

    Topic set to EXT: install
  3. Nicole Hummel voted on patch set 1 CR +1 02/09/15, 16:21

  4. Nicole Hummel voted on patch set 1 V +1 02/09/15, 16:39

  5. Christian Kuhn commented on patch set 1 CR +2 V +2 02/09/15, 17:10

    Hint: FailsafeView is basically a wrapper around StandaloneView that steps in if so evil issues exist in the system that fluid can not come up. Otherwise rendering is given to StandaloneView. So, this is easy to test: If install tool still comes up with the patch, everything is fine ...
  6. Christian Kuhn merged patch set 1 02/09/15, 17:10