36807[TASK] Introduce CSS based trees
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Andreas Kienast +1
- Xavier Perseguers +1
- Nicole Hummel +1
- Benjamin Kott +1
- Michael Oehlhof +1
-
Verified V +2
- Georg Ringer +2
- Andreas Kienast +1
- Xavier Perseguers +1
- Nicole Hummel +1
- Benjamin Kott +1
- Michael Oehlhof +1
- Andy Grunwald +1
Issues 1
Files 3
Review log 23
-
Andreas Kienast uploaded patch set 1 02/10/15, 16:46
-
Andreas Kienast uploaded patch set 2 02/12/15, 17:02
-
Wouter Wolters commented on patch set 2 02/12/15, 17:57
NewRecordController.php:488space after the dot missing -
Andreas Kienast uploaded patch set 3 02/13/15, 07:05
-
Andreas Kienast commented on patch set 3 02/13/15, 07:06
Those were too obvious, thanks :) -
Mathias Schreiber voted on patch set 3 CR +1 V +1 02/13/15, 13:24
-
Nicole Hummel commented on patch set 3 02/13/15, 13:50
t3skin.css:9070I would prefer to show list elements with font-size: normal -
Andreas Kienast uploaded patch set 4 02/15/15, 12:38
-
Nicole Hummel commented on patch set 4 02/15/15, 12:54
t3skin.css:9704This was removed with patch 90cd2f4 -
Nicole Hummel commented on patch set 4 CR +1 V +1 02/15/15, 12:59
Stupid me - everything is okay -
Michael Oehlhof commented on patch set 4 CR +1 V +1 02/16/15, 19:22
When it is with intent that the left vertical line is missing, than it is ok. -
Benjamin Kott commented on patch set 4 V -1 CR +1 02/16/15, 19:26
_element_tree.less:17would be nice if we can get rid of the typo3 styles. to be in line with bootstrap (http://getbootstrap.com/css/#type-lists) it would be awesome if we could change it to list-tree_element_tree.less:45since everything else is set in em we should use it here also. minor correction to 1em would be nice._element_tree.less:62no padding needed on right side minor correction to 1.25em would be nice.t3skin.css:9704Replyhttps://review.typo3.org/#/c/36876/ was introduced here -
Andreas Kienast uploaded patch set 5 02/16/15, 19:41
-
Michael Oehlhof voted on patch set 5 CR +1 V +1 02/16/15, 19:46
-
Benjamin Kott uploaded patch set 6 02/16/15, 20:12
-
Andreas Kienast voted on patch set 6 CR +1 V +1 02/16/15, 20:16
-
Benjamin Kott commented on patch set 6 CR +1 V +1 02/16/15, 20:16
Adreas and i agreed that we are using here also dotted lines instead of solid ones. -
Nicole Hummel voted on patch set 6 CR +1 V +1 02/16/15, 20:28
-
Michael Oehlhof voted on patch set 6 CR +1 V +1 02/16/15, 21:14
-
Andy Grunwald commented on patch set 6 V +1 02/16/15, 21:18
Github tests: success Pull request: https://github.com/typo3-ci/TYPO3.CMS-pre-merge-tests/pull/27 Service: continuous-integration/travis-ci Description: The Travis CI build passed URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/50996862 -
Xavier Perseguers voted on patch set 6 CR +1 V +1 02/17/15, 09:39
-
Georg Ringer voted on patch set 6 CR +2 V +2 02/19/15, 07:25
-
Georg Ringer merged patch set 6 02/19/15, 07:25
NewRecordController.php:413