Review main Merged

36807[TASK] Introduce CSS based trees

Andreas Kienast CR +2 V +2 Normal +119 −57 updated 02/19/15, 07:25

Commit message

A new CSS based tree is introduced. As first step, the
trees in the "New record" wizard are ported to use it.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Andreas Kienast +1
    • Xavier Perseguers +1
    • Nicole Hummel +1
    • Benjamin Kott +1
    • Michael Oehlhof +1
  • Verified V +2
    • Georg Ringer +2
    • Andreas Kienast +1
    • Xavier Perseguers +1
    • Nicole Hummel +1
    • Benjamin Kott +1
    • Michael Oehlhof +1
    • Andy Grunwald +1

Issues 1

Files 3

Review log 23

  1. Andreas Kienast uploaded patch set 1 02/10/15, 16:46

  2. Andreas Kienast uploaded patch set 2 02/12/15, 17:02

  3. Wouter Wolters commented on patch set 2 02/12/15, 17:57

    NewRecordController.php:413

    empty string not needed here in the beginning.

    NewRecordController.php:488

    space after the dot missing
  4. Andreas Kienast uploaded patch set 3 02/13/15, 07:05

  5. Andreas Kienast commented on patch set 3 02/13/15, 07:06

    Those were too obvious, thanks :)
  6. Mathias Schreiber voted on patch set 3 CR +1 V +1 02/13/15, 13:24

  7. Nicole Hummel commented on patch set 3 02/13/15, 13:50

    t3skin.css:9070

    I would prefer to show list elements with font-size: normal
  8. Andreas Kienast uploaded patch set 4 02/15/15, 12:38

  9. Nicole Hummel commented on patch set 4 02/15/15, 12:54

    t3skin.css:9704

    This was removed with patch 90cd2f4
  10. Nicole Hummel commented on patch set 4 CR +1 V +1 02/15/15, 12:59

    Stupid me - everything is okay
  11. Michael Oehlhof commented on patch set 4 CR +1 V +1 02/16/15, 19:22

    When it is with intent that the left vertical line is missing, than it is ok.
  12. Benjamin Kott commented on patch set 4 V -1 CR +1 02/16/15, 19:26

    _element_tree.less:17

    would be nice if we can get rid of the typo3 styles. to be in line with bootstrap (http://getbootstrap.com/css/#type-lists) it would be awesome if we could change it to list-tree

    _element_tree.less:45

    since everything else is set in em we should use it here also. minor correction to 1em would be nice.

    _element_tree.less:62

    no padding needed on right side minor correction to 1.25em would be nice.

    t3skin.css:9704 Reply

  13. Andreas Kienast uploaded patch set 5 02/16/15, 19:41

  14. Michael Oehlhof voted on patch set 5 CR +1 V +1 02/16/15, 19:46

  15. Benjamin Kott uploaded patch set 6 02/16/15, 20:12

  16. Andreas Kienast voted on patch set 6 CR +1 V +1 02/16/15, 20:16

  17. Benjamin Kott commented on patch set 6 CR +1 V +1 02/16/15, 20:16

    Adreas and i agreed that we are using here also dotted lines instead of solid ones.
  18. Nicole Hummel voted on patch set 6 CR +1 V +1 02/16/15, 20:28

  19. Michael Oehlhof voted on patch set 6 CR +1 V +1 02/16/15, 21:14

  20. Andy Grunwald commented on patch set 6 V +1 02/16/15, 21:18

    Github tests: success Pull request: https://github.com/typo3-ci/TYPO3.CMS-pre-merge-tests/pull/27 Service: continuous-integration/travis-ci Description: The Travis CI build passed URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/50996862
  21. Xavier Perseguers voted on patch set 6 CR +1 V +1 02/17/15, 09:39

  22. Georg Ringer voted on patch set 6 CR +2 V +2 02/19/15, 07:25

  23. Georg Ringer merged patch set 6 02/19/15, 07:25