Review main Merged

36813[BUGFIX] Correctly store values of select fields

Nicole Hummel CR +2 V +2 Easy +3 −9 updated 02/11/15, 09:36

Commit message

Due to a wrong position of the hidden helper field, the values of select
boxes aren't submitted. This patch removes the hidden field as it is
unused anyway.

Furthermore a double encoding of the option value is prevented.

Review

  • Code review CR +2
    • Alexander Opitz +2
    • Frederic Gaus +1
    • Markus Klein +1
    • Nicole Hummel +1
  • Verified V +2
    • Alexander Opitz +2
    • Frederic Gaus +1
    • Markus Klein +1
    • Nicole Hummel +1

Issues 1

Files 2

Review log 17

  1. Nicole Hummel uploaded patch set 1 02/10/15, 22:01

  2. Nicole Hummel uploaded patch set 2 02/10/15, 22:22

  3. Markus Klein commented on patch set 2 V +1 02/10/15, 22:38

    Works, but I don't get why we need a hidden field in parallel to the select field.
  4. Nicole Hummel uploaded patch set 3 02/10/15, 22:56

  5. Markus Klein uploaded patch set 4 02/10/15, 23:15

  6. Markus Klein voted on patch set 4 CR +1 V +1 02/10/15, 23:17

  7. Nicole Hummel uploaded patch set 5 02/11/15, 07:50

  8. Markus Klein voted on patch set 5 CR +1 V +1 02/11/15, 08:15

  9. Frederic Gaus voted on patch set 5 CR +1 V +1 02/11/15, 08:23

  10. Markus Klein commented on patch set 5 02/11/15, 08:43

    The hidden field seems useless on CMS 7!
  11. Markus Klein uploaded patch set 6 02/11/15, 09:21

  12. Markus Klein updated the commit message in patch set 7 02/11/15, 09:22

  13. Markus Klein voted on patch set 7 CR +1 V +1 02/11/15, 09:23

  14. Nicole Hummel voted on patch set 7 CR +1 V +1 02/11/15, 09:25

  15. Frederic Gaus voted on patch set 7 CR +1 V +1 02/11/15, 09:35

  16. Alexander Opitz voted on patch set 7 V +2 CR +2 02/11/15, 09:36

  17. Alexander Opitz merged patch set 7 02/11/15, 09:36