Review main Merged

36823[CLEANUP] Unification of function naming

Frederic Gaus CR +2 V +2 Easy +6 −6 updated 02/28/15, 16:39

Commit message

The usage of getBackendUser and getBackendUserAuthentication is mixed
up in the core. But at least in inheritance this should be consistent.

Rename ScheduleModuleController::getBackendUserAuthentication to
ScheduleModuleController::getBackendUser

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Stefan Neufeind +1
  • Verified V +2
    • Wouter Wolters +2

Issues 1

Files 1

Review log 9

  1. Frederic Gaus uploaded patch set 1 02/11/15, 10:00

  2. Stefan Neufeind commented on patch set 1 02/16/15, 12:59

    Well, but the object is a \TYPO3\CMS\Core\Authentication\BackendUserAuthentication
  3. Stefan Neufeind voted on patch set 1 CR -1 02/16/15, 13:00

  4. Frederic Gaus commented on patch set 1 02/16/15, 13:09

    Yes, Stefan, this is true. But it is called "getBackendUser" in the parent class. With this patch the definition of getBackendUser could be removed completely but as discussed on slack the coupling should not be hidden in inheritance.
  5. Stefan Neufeind commented on patch set 1 CR +1 02/16/15, 13:45

    Okay, thanks for the clarification.
  6. Wouter Wolters voted on patch set 1 CR +1 02/19/15, 17:58

  7. Wouter Wolters voted on patch set 1 V +1 02/27/15, 23:20

  8. Wouter Wolters voted on patch set 1 V +2 CR +2 02/28/15, 16:39

  9. Wouter Wolters merged patch set 1 02/28/15, 16:39