Review main Merged

36827[BUGFIX] DBAL: Remove quoting from tablename for sequences

Andreas Kienast CR +2 V +2 Normal +60 −11 updated 09/28/15, 05:51

Commit message

Trim the quotes from the tables names when creating sequences, otherwise
the SQL statements are broken. Also, the bogus sequence prefix is
removed from the trigger name.

Review

  • Code review CR +2
    • Morton Jonuschat +2
    • Anja Leichsenring +1
  • Verified V +2
    • Morton Jonuschat +2
    • Anja Leichsenring +1

Issues 1

Files 3

Review log 17

  1. Andreas Kienast uploaded patch set 1 02/11/15, 13:13

  2. Andreas Kienast uploaded patch set 2 02/11/15, 13:16

  3. Andreas Kienast updated the commit message in patch set 3 02/11/15, 13:19

  4. Andreas Kienast commented on patch set 3 V -1 02/11/15, 13:22

    I refactor the complete part here.
  5. Mathias Schreiber updated the commit message in patch set 4 02/11/15, 13:22

  6. Andreas Kienast voted on patch set 4 V -1 02/11/15, 13:23

  7. Andreas Kienast uploaded patch set 5 02/11/15, 13:40

  8. Andreas Kienast commented on patch set 5 V -1 02/11/15, 14:09

    working on it
  9. Andreas Kienast uploaded patch set 6 02/11/15, 14:13

  10. Andreas Kienast uploaded patch set 7 05/18/15, 06:59

  11. Andreas Kienast commented on patch set 6 05/18/15, 06:59

    rebased
  12. Andreas Kienast uploaded patch set 8 09/25/15, 08:35

  13. Morton Jonuschat commented on patch set 8 CR +1 09/25/15, 11:04

    Looks good by reading, but I've got no idea how to verify that
  14. Andreas Kienast commented on patch set 8 09/25/15, 13:13

    You can verify that by having very much spare time and setting up an Oracle database server :)
  15. Anja Leichsenring voted on patch set 8 CR +1 V +1 09/28/15, 05:50

  16. Morton Jonuschat voted on patch set 8 CR +2 V +2 09/28/15, 05:51

  17. Morton Jonuschat merged patch set 8 09/28/15, 05:51