Review main Merged

36828[FEATURE] Add API for requestedId

Frederic Gaus CR +2 V +2 Easy +27 −1 updated 03/15/15, 16:53

Commit message

Add an API to TypoScriptFrontendController to receive the original
requested ID.

Review

  • Code review CR +2
    • Benni Mack +2
    • Georg Ringer +1
    • Christian Kuhn +1
  • Verified V +2
    • Benni Mack +2
    • Georg Ringer +1

Issues 1

Files 2

Review log 13

  1. Frederic Gaus uploaded patch set 1 02/11/15, 13:44

  2. Mathias Brodala commented on patch set 1 CR -1 02/11/15, 14:03

    Since it's a feature, please add a .rst and mention at least one example what this is good for.

    TypoScriptFrontendController.php:4620

    Returns

    TypoScriptFrontendController.php:4620

    originally
  3. Benni Mack voted on patch set 1 V +1 02/25/15, 14:33

  4. Benni Mack voted on patch set 1 V 0 02/25/15, 23:19

  5. Benni Mack uploaded patch set 2 03/06/15, 05:04

  6. Benni Mack voted on patch set 2 CR +1 03/06/15, 05:04

  7. Georg Ringer commented on patch set 2 V +1 CR +1 03/06/15, 05:14

    can we please have that for 6.2 as well? Hey we need to deal with this version some more time...
  8. Benni Mack commented on patch set 2 03/06/15, 06:29

    Fine with me. It's actually a "TASK" in my eyes anyway, as the value is set already in the code. But let's check with Ernesto.
  9. Mathias Brodala commented on patch set 2 03/06/15, 08:26

    I still don't get what the purpose of this is. Can you elaborate on this a bit?
  10. Christian Kuhn commented on patch set 2 CR +1 03/06/15, 16:17

    That's imho a side feature, I see no pressing urge to have this in 6.2. +1 on reading for master, though.
  11. Christian Kuhn commented on patch set 2 03/06/15, 16:17

    BTW: This is a code change only, imho we don't need a .rst file for that, too.
  12. Benni Mack voted on patch set 2 CR +2 V +2 03/15/15, 16:53

  13. Benni Mack merged patch set 2 03/15/15, 16:53