Review main Merged

36844[TASK] Proofread and move 7.1 documentation

Mathias Schreiber CR +2 V +2 Expert +817 −781 updated 02/12/15, 15:06

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Michael Oehlhof +1
  • Verified V +2
    • Christian Kuhn +2
    • Michael Oehlhof +1

Issues 1

Files 114

Show 94 more files

Review log 15

  1. Mathias Schreiber uploaded patch set 1 02/11/15, 17:14

  2. Christian Kuhn commented on patch set 1 02/11/15, 18:23

    Breaking-63431-BackendToolbarRefactored.rst:14

    ave -> are
  3. Christian Kuhn uploaded patch set 2 02/11/15, 18:24

  4. Christian Kuhn commented on patch set 2 CR +1 V +1 02/11/15, 18:24

    Thank you!
  5. Wouter Wolters voted on patch set 2 V +1 CR +1 02/11/15, 18:30

  6. Jigal van Hemert commented on patch set 1 02/11/15, 18:52

    Some textual changes and one issue with the information itself. For version 1 of the patch.

    Breaking-63431-BackendToolbarRefactored.rst:14

    "ave" -> "have"

    Breaking-63437-ClassAliasesMovedToLegacyExtension.rst:9

    "has been" -> "was"? It's an event fully completed longer ago in the past.

    Breaking-63437-ClassAliasesMovedToLegacyExtension.rst:11

    "will be removed at some point during the development of TYPO3 CMS 7"?

    Breaking-63437-ClassAliasesMovedToLegacyExtension.rst:39

    "should": is it optional?

    Breaking-63780-RemoveWordStringsFromReferenceIndex.rst:8

    space before "have"?

    Breaking-64143-FlagFilesMoved.rst:8

    "have been" -> "has been"; collection is singular.

    Breaking-64229-TrimSubmittedLoginFormData.rst:9

    "following" -> "trailing" "whitespaces" -> "whitespace" (it's a sort name: 'whitespace characters')

    Breaking-64229-TrimSubmittedLoginFormData.rst:10

    "whitespace"

    Breaking-64229-TrimSubmittedLoginFormData.rst:16

    "whitespace" (and a few other occasions on this page)

    Breaking-64361-ComposerClassLoading.rst:19

    "a" removed.

    Breaking-64361-ComposerClassLoading.rst:27

    "Resolving classes"

    Breaking-64643-RemoveEnableTypo3tempDbTracking.rst:8

    "has" -> "have"; logic and database table...

    Deprecation-24387-Xhtml2.rst:21

    "different" -> "other"

    Deprecation-25112-andWhere.rst:8

    "has been marked as deprecated"

    Deprecation-25112-andWhere.rst:25

    It's not a choice between 'where' and 'markers'. 'markers' defines markers that are inserted in other properties and these markers are always escaped and quoted (if necessary) for use in queries. (See TSref)

    Deprecation-25112-andWhere.rst:36

    This is an unsafe construction. The contents of "field:sorting" may contain specially constructed code to break queries.

    Deprecation-46523-BackendUtilityImplodeTSParams.rst:8

    "marked as deprecated"

    Deprecation-46770-LocalImageProcessorGraphicalFunctions.rst:8

    "has been marked as deprecated"

    Deprecation-61605-ChangeNamingOfIncludeJSlibs.rst:10

    "has been marked as deprecated"

    Deprecation-64922-DeprecatedEntryPoints.rst:8

    "have been deprecated"

    Feature-63207-SplitActionButtonsIntoGroups.rst:8

    "are" -> "have been"

    Feature-63207-SplitActionButtonsIntoGroups.rst:9

    "action" -> "actions"

    Feature-63600-CustomTypoScriptConditionsInBackend.rst:12

    "fully" (two L's)
  7. Mathias Schreiber uploaded patch set 3 02/11/15, 19:58

  8. Christian Kuhn voted on patch set 3 CR +1 V +1 02/11/15, 21:54

  9. Wouter Wolters voted on patch set 3 V +1 CR +1 02/11/15, 22:04

  10. Michael Oehlhof commented on patch set 3 CR +1 V +1 02/11/15, 23:21

    Apart from some odds and ends will be OK.

    Breaking-63431-BackendToolbarRefactored.rst:10

    Should be 2 empty lines

    Breaking-63431-BackendToolbarRefactored.rst:18

    Should be 2 empty lines

    Breaking-63431-BackendToolbarRefactored.rst:24

    Should be 2 empty lines

    Breaking-63437-ClassAliasesMovedToLegacyExtension.rst:23

    Should be 2 empty lines

    Breaking-63437-ClassAliasesMovedToLegacyExtension.rst:29

    Should be 2 empty lines

    Breaking-64102-MoveT3TableAndT3ButtonToBootstrap.rst:16

    There is one "and" too much.

    Breaking-64696-MoveSearchCTypeToLegacyExtension.rst:8

    ContentObjects should be 2 words and lower case

    Breaking-64696-MoveSearchCTypeToLegacyExtension.rst:10

    Should be 2 empty lines

    Breaking-64696-MoveSearchCTypeToLegacyExtension.rst:21

    Content Element and Content Object should be lowercase

    Breaking-64696-MoveSearchCTypeToLegacyExtension.rst:22

    Should be 2 empty lines

    Deprecation-62329-DocumentTemplate-table.rst:2

    Missing parenthesis at function name

    Deprecation-63852-FormEngine-getAvailableLanguages.rst:15

    Should be 2 empty lines

    Deprecation-63852-FormEngine-getAvailableLanguages.rst:20

    Should be 2 empty lines

    Deprecation-63855-FormEngine-sL.rst:2

    Missing parenthesis at function name

    Deprecation-63864-FormEngine-renderVDEFDiff.rst:2

    Missing parenthesis at function name

    Deprecation-63889-FormEngine-getTSCpid.rst:2

    Missing parenthesis at function name

    Deprecation-64134-TypoScriptTemplateObjectBrowserModuleFunctionController-verify_TSobjects.rst:2

    Missing parenthesis at function name

    Deprecation-64922-DeprecatedEntryPoints.rst:16

    Should be 2 empty lines

    Deprecation-64922-DeprecatedEntryPoints.rst:21

    Should be 2 empty lines
  11. Mathias Schreiber commented on patch set 3 CR -1 V -1 02/12/15, 08:20

    on it.. rST and me will NEVER be friends
  12. Mathias Schreiber uploaded patch set 4 02/12/15, 08:31

  13. Michael Oehlhof voted on patch set 4 CR +1 V +1 02/12/15, 14:18

  14. Christian Kuhn voted on patch set 4 CR +2 V +2 02/12/15, 15:05

  15. Christian Kuhn merged patch set 4 02/12/15, 15:06