Review main Merged

36964[BUGFIX] Don't trigger clearable on ENTER

Andreas Kienast CR +2 V +2 Easy +2 −2 updated 02/17/15, 09:49

Commit message

Add a type="button" to the clearable button to prevent trigger stealing
by pressing enter in it's input field.

Review

  • Code review CR +2
    • Xavier Perseguers +2
    • Jigal van Hemert +1
  • Verified V +2
    • Xavier Perseguers +2
    • Jigal van Hemert +1

Issues 1

Files 1

Review log 5

  1. Andreas Kienast uploaded patch set 1 02/17/15, 08:36

  2. Andreas Kienast uploaded patch set 2 02/17/15, 08:38

  3. Jigal van Hemert commented on patch set 2 CR +1 V +1 02/17/15, 09:05

    Works fine, but the issue is not present in "normal" input fields with a clearable button.
  4. Xavier Perseguers voted on patch set 2 CR +2 V +2 02/17/15, 09:49

  5. Xavier Perseguers merged patch set 2 02/17/15, 09:49