Review main Abandoned

36976[BUGFIX] Fix button margins by adding a removeWhitespace ViewHelper

Mathias Schreiber CR 0 V 0 Normal +166 −40 updated 05/14/15, 21:59

Commit message

Since Bootstrap buttons have a problem with whitespace between them
we introduce a new "RemoveWhitespace" Viewhelper that should be used
to wrap button groups.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 5

Review log 42

Show 17 earlier messages
  1. Mathias Schreiber uploaded patch set 1 02/17/15, 18:44

  2. Felix Kopp commented on patch set 1 02/17/15, 18:56

    Will try to review tomorrow
  3. Andreas Kienast uploaded patch set 2 02/17/15, 19:21

  4. Andreas Kienast voted on patch set 2 CR +1 V +1 02/17/15, 19:21

  5. Andy Grunwald commented on patch set 2 V +1 02/17/15, 21:31

    Github tests: success Pull request: https://github.com/typo3-ci/TYPO3.CMS-pre-merge-tests/pull/40 Service: continuous-integration/travis-ci/push Description: The Travis CI build passed URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/51122611 Service: continuous-integration/travis-ci/pr Description: The Travis CI build passed URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/51137457
  6. Andy Grunwald commented on patch set 2 02/17/15, 21:50

    Github tests: success Pull request: https://github.com/typo3-ci/TYPO3.CMS-pre-merge-tests/pull/41 Service: continuous-integration/travis-ci/push Description: The Travis CI build passed URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/51122611 Service: continuous-integration/travis-ci/pr Description: The Travis CI build passed URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/51140097
  7. Wouter Wolters commented on patch set 2 02/17/15, 22:25

    RemoveWhitespaceViewHelper.php:15

    enter here

    RemoveWhitespaceViewHelper.php:20

    one * too much

    RemoveWhitespaceViewHelper.php:32

    can we return the data dircectly?
  8. Andreas Kienast uploaded patch set 3 02/18/15, 07:10

  9. Mathias Brodala commented on patch set 3 CR -1 02/18/15, 07:14

    RemoveWhitespaceViewHelper.php:20

    This sounds very specific where in fact it's not. Should be: "Viewhelper which removes whitespace between HTML/XML tags". But even then the viewhelper name does not reflect its purpose at all.

    RemoveWhitespaceViewHelper.php:32

    Since the pattern is only used once, there's not much point keeping it as variable.
  10. Mathias Brodala commented on patch set 3 02/18/15, 07:16

    Maybe at least introduce a "Tag" directory where this viewhelper is placed. This would make <f:format.tag.removeWhitespace/> a bit more obvious.
  11. Andreas Kienast uploaded patch set 4 02/18/15, 07:20

  12. Mathias Brodala commented on patch set 4 CR -1 02/18/15, 07:24

    One more.

    RemoveWhitespaceViewHelper.php:26

    Sorry, didn't notice this one. Should be "Removes whitespace between children tags." (Restriction to buttons removed here too.)
  13. Andreas Kienast uploaded patch set 5 02/18/15, 07:27

  14. Mathias Brodala voted on patch set 5 CR +1 02/18/15, 07:40

  15. Andy Grunwald commented on patch set 5 02/18/15, 08:05

    Github tests: success Pull request: https://github.com/typo3-ci/TYPO3.CMS-pre-merge-tests/pull/47 Service: continuous-integration/travis-ci/push Description: The Travis CI build passed URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/51192345 Service: continuous-integration/travis-ci/pr Description: The Travis CI build passed URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/51194114
  16. Mathias Schreiber uploaded patch set 6 02/18/15, 10:18

  17. Mathias Schreiber commented on patch set 6 CR -2 02/18/15, 10:18

    damn it...
  1. Mathias Schreiber uploaded patch set 7 02/18/15, 10:21

  2. Mathias Brodala commented on patch set 7 02/18/15, 10:26

    @Mathias: any reason for this change? This viewhelper could very well be general-purpose although one could argue about its location.
  3. Mathias Schreiber voted on patch set 7 CR 0 02/18/15, 10:27

  4. Mathias Schreiber commented on patch set 7 02/18/15, 10:30

    git fetch ssh://[YOUR_USERNAME]@review.typo3.org:29418/Packages/TYPO3.CMS refs/changes/76/36976/7 && git cherry-pick FETCH_HEAD Move it... This whole discussion is pointless and going nowhere. Argueing on the location of the VH (which is at the place YOU wanted it to be) binds two developers right now. Pick the change, do your changes, push them. But this entire "Hey, push another patchset and maybe you're lucky" approach is slowing down the development and highly frustrating.
  5. Mathias Brodala commented on patch set 7 02/18/15, 10:33

    I said one COULD argue. I am very well aware that there is currently no other place to put general-purpose viewhelpers aside Fluid. The current location would be OK with me but I do not understand the implied limitation to button groups where the code does not have it. And I am aware that I can do changes myself but I was asking for opinions on this from others.
  6. Mathias Schreiber commented on patch set 7 02/18/15, 10:41

    All these opinions have been collected on Slack already. The idea is to discuss first, find consensus and then push to gerrit. If it is too complicated to explain on Slack, prefix with [WIP] so everybody knows. Tbh I don't really see the usecase in the wild, but we don't have a strategy on where to put such VHs. Something like f.internal.format.tag might be an option or we supply our own set of VHs in the first place because we need to prevent drifting too far off Upstream Fluid. The assessment was to temporarily introduce this VH until we either adjust the CSS of Bootstrap OR get this VH into upstream Fluid OR have a strategy on where to put those internal and/or situational VHs.
  7. Mathias Brodala commented on patch set 7 02/18/15, 11:13

    I was under the impression that discussions should happen within the review system. No one will know what opinions where stated on this change in a few years unless it's written on Forge/Gerrit. Slack on the other side is basically a closed system without public access and a very limited message lifetime. As for the actual issue itself: I don't see it on cms70.demo.typo3.org, gotta fire up a master machine to see the latest state.
  8. Andy Grunwald commented on patch set 7 02/18/15, 11:18

    Github tests: success Pull request: https://github.com/typo3-ci/TYPO3.CMS-pre-merge-tests/pull/54 Service: continuous-integration/travis-ci/push Description: The Travis CI build passed URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/51208267 Service: continuous-integration/travis-ci/pr Description: The Travis CI build passed URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/51211263
  9. Andy Grunwald commented on patch set 7 02/18/15, 13:45

    Github tests: success Pull request: https://github.com/typo3-ci/TYPO3.CMS-pre-merge-tests/pull/62 Service: continuous-integration/travis-ci/push Description: The Travis CI build passed URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/51208267 Service: continuous-integration/travis-ci/pr Description: The Travis CI build passed URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/51226411
  10. Mathias Brodala uploaded patch set 8 02/18/15, 14:06

  11. Mathias Brodala commented on patch set 8 CR +1 02/18/15, 14:07

    I was able to see the issue with the latest master. If this viewhelper is only a workaround, clearly indicating that purpose should be enough.
  12. Andreas Kienast voted on patch set 8 CR +1 V +1 02/18/15, 14:09

  13. Helmut Hummel commented on patch set 8 CR -1 02/18/15, 14:11

    can we move the view helper to "backend" extension please and just name it "buttonGroupViewHelper"
  14. Helmut Hummel voted on patch set 8 CR 0 02/18/15, 14:16

  15. Mathias Brodala commented on patch set 8 02/18/15, 14:19

    @Helmut: that would imply a dependency of EXT:beuser, EXT:extensionmanager and EXT:recycler on EXT:backend. Also ButtonGroupViewHelper would imply managed output of button groups, similar to the way the ImageViewHelper generates its output.
  16. Mathias Schreiber commented on patch set 8 02/18/15, 14:19

    they HAVE that dependency, since they are BE modules
  17. Helmut Hummel commented on patch set 8 02/18/15, 14:23

    ignore my comment and go ahead however you like
  18. Mathias Schreiber abandoned the change 02/18/15, 14:25

    Jup. Fluid seems to be a touchy subject. Too touchy and "everybody's got three opinions on it" for me to keep on going with this approach. I will try a CSS based solution.
  19. Andy Grunwald commented on patch set 8 03/13/15, 19:45

    Github tests: success Pull request: https://github.com/typo3-ci/TYPO3.CMS-pre-merge-tests/pull/65 Service: continuous-integration/travis-ci/push Description: The Travis CI build passed URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/51231747 Service: continuous-integration/travis-ci/pr Description: The Travis CI build passed URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/54292299
  20. Andy Grunwald commented on patch set 8 03/13/15, 20:08

    Github tests: success Pull request: https://github.com/typo3-ci/TYPO3.CMS-pre-merge-tests/pull/69 Service: continuous-integration/travis-ci/push Description: The Travis CI build passed URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/51231747 Service: continuous-integration/travis-ci/pr Description: The Travis CI build passed URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/54296785
  21. Andy Grunwald commented on patch set 8 03/13/15, 20:21

    Github tests: success Pull request: https://github.com/typo3-ci/TYPO3.CMS-pre-merge-tests/pull/70 Service: continuous-integration/travis-ci/push Description: The Travis CI build passed URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/51231747 Service: continuous-integration/travis-ci/pr Description: The Travis CI build passed URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/54298198
  22. Mathias Brodala commented on patch set 8 03/16/15, 11:17

    Can we abandon this one? It was fixed via CSS in the meantime.
  23. Mathias Schreiber commented on patch set 8 03/16/15, 11:20

    it IS abandoned since Feb 18th :)
  24. Andy Grunwald commented on patch set 8 05/14/15, 21:54

    Github tests: success Pull request: https://github.com/typo3-ci/TYPO3.CMS-pre-merge-tests/pull/73 Service: continuous-integration/travis-ci/push Description: The Travis CI build passed URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/51231747 Service: continuous-integration/travis-ci/pr Description: The Travis CI build passed URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/62616262
  25. Andy Grunwald commented on patch set 8 05/14/15, 21:59

    Github tests: success Pull request: https://github.com/typo3-ci/TYPO3.CMS-pre-merge-tests/pull/75 Service: continuous-integration/travis-ci/push Description: The Travis CI build passed URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/51231747 Service: continuous-integration/travis-ci/pr Description: The Travis CI build passed URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/62616262