Review main Merged

36982[BUGFIX] Database integrity check: Display correct hover text

Michael Oehlhof CR +2 V +2 Easy +1 −1 updated 02/19/15, 20:42

Commit message

In the overview of the database integrity check the title and alt tag
of the 4 icons were displayed with a non translated text.
Now the correct text is shown.

Review

  • Code review CR +2
    • Markus Klein +2
    • Wouter Wolters +1
    • Christian Kuhn +1
  • Verified V +2
    • Markus Klein +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 15

  1. Michael Oehlhof uploaded patch set 1 02/17/15, 22:43

  2. Michael Oehlhof updated the commit message in patch set 2 02/17/15, 22:44

  3. Andy Grunwald commented on patch set 2 02/18/15, 08:24

    Github tests: success Pull request: https://github.com/typo3-ci/TYPO3.CMS-pre-merge-tests/pull/48 Service: continuous-integration/travis-ci/push Description: The Travis CI build passed URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/51148617 Service: continuous-integration/travis-ci/pr Description: The Travis CI build passed URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/51196093
  4. Andy Grunwald commented on patch set 2 02/18/15, 11:02

    Github tests: success Pull request: https://github.com/typo3-ci/TYPO3.CMS-pre-merge-tests/pull/50 Service: continuous-integration/travis-ci/push Description: The Travis CI build passed URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/51148617 Service: continuous-integration/travis-ci/pr Description: The Travis CI build passed URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/51211182
  5. Andy Grunwald commented on patch set 2 02/18/15, 12:40

    Github tests: success Pull request: https://github.com/typo3-ci/TYPO3.CMS-pre-merge-tests/pull/56 Service: continuous-integration/travis-ci/push Description: The Travis CI build passed URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/51148617 Service: continuous-integration/travis-ci/pr Description: The Travis CI build passed URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/51221731
  6. Andy Grunwald commented on patch set 2 02/18/15, 13:40

    Github tests: success Pull request: https://github.com/typo3-ci/TYPO3.CMS-pre-merge-tests/pull/60 Service: continuous-integration/travis-ci/push Description: The Travis CI build passed URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/51148617 Service: continuous-integration/travis-ci/pr Description: The Travis CI build passed URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/51226376
  7. Wouter Wolters voted on patch set 2 V +1 CR +1 02/19/15, 17:50

  8. Markus Klein commented on patch set 2 CR +1 V +1 02/19/15, 19:58

    IntegrityOverview.html:6

    could be shortened to: {f:translate(key: name)}
  9. Michael Oehlhof uploaded patch set 3 02/19/15, 20:25

  10. Michael Oehlhof commented on patch set 3 02/19/15, 20:26

    Done shortened
  11. Christian Kuhn commented on patch set 2 02/19/15, 20:34

    working on it ...
  12. Christian Kuhn commented on patch set 3 CR +1 V +1 02/19/15, 20:36

    good catch!
  13. Wouter Wolters voted on patch set 3 CR +1 02/19/15, 20:36

  14. Markus Klein voted on patch set 3 CR +2 V +2 02/19/15, 20:42

  15. Markus Klein merged patch set 3 02/19/15, 20:42