Review main Merged

37024[BUGFIX] Display error message for "Check for broken extensions"

Nicole Hummel CR +2 V +2 Easy +7 −6 updated 02/20/15, 18:44

Commit message

If you try to uninstall an extension, which is needed by another one,
the process triggers an error without any information for the user. This
patch catches the exception and shows it in frontend.

Review

  • Code review CR +2
    • Markus Klein +2
    • Alexander Opitz +1
  • Verified V +2
    • Markus Klein +2
    • Alexander Opitz +1

Issues 1

Files 2

Review log 12

  1. Nicole Hummel uploaded patch set 1 02/19/15, 16:24

  2. Markus Klein voted on patch set 1 CR +1 V +1 02/19/15, 16:28

  3. Andreas Kienast voted on patch set 1 V +1 CR +1 02/19/15, 16:32

  4. Wouter Wolters voted on patch set 1 CR +1 02/19/15, 17:40

  5. Christian Kuhn commented on patch set 1 02/19/15, 18:57

    UninstallExtension.php:23

    this is no longer true.

    UninstallExtension.php:36

    also, these lines could get some love - they were obviously not adapted after this code was switched to package management ...
  6. Markus Klein uploaded patch set 2 02/20/15, 00:19

  7. Markus Klein voted on patch set 2 CR +1 V +1 02/20/15, 00:21

  8. Alexander Opitz commented on patch set 2 V +1 CR -1 02/20/15, 13:29

    UninstallExtension.php:35

    We should update this part IMHO
  9. Nicole Hummel uploaded patch set 3 02/20/15, 13:36

  10. Alexander Opitz voted on patch set 3 V +1 CR +1 02/20/15, 13:43

  11. Markus Klein voted on patch set 3 CR +2 V +2 02/20/15, 18:44

  12. Markus Klein merged patch set 3 02/20/15, 18:44