37025[BUGFIX] Install tool error message if session file not writeable
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Markus Klein +1
- Frank Nägler +1
-
Verified V +2
- Wouter Wolters +2
- Markus Klein +1
Issues 1
Files 1
Review log 11
-
Christian Kuhn uploaded patch set 1 02/19/15, 16:38
-
Markus Klein commented on patch set 1 CR +1 V +1 02/19/15, 16:49
makes sense! (no way to test for me here, so putting a blind v+1 here) -
Christian Kuhn commented on patch set 1 02/19/15, 16:59
i'm still testing some scenarios here to make sure this patch is no problem. -
Markus Klein commented on patch set 1 02/19/15, 17:11
btw: we need something similar for PHP session handling in general. I once had the issue of PHP not being able to write the session file. This causes failing logins to BE, but no error message. phpmyadmin revealed the issue to me back then. -
Wouter Wolters commented on patch set 1 02/19/15, 17:42
SessionService.php:376Exception, short variant?SessionService.php:377subdirectories -
Christian Kuhn uploaded patch set 2 02/19/15, 18:22
-
Christian Kuhn commented on patch set 2 02/19/15, 18:25
Tested every scenario that came to my mind - including fresh install - with this patch applied now. Looks good to me. -
Markus Klein voted on patch set 2 CR +1 V +1 02/19/15, 19:58
-
Frank Nägler voted on patch set 2 CR +1 02/19/15, 20:52
-
Wouter Wolters voted on patch set 2 V +2 CR +2 02/19/15, 21:11
-
Wouter Wolters merged patch set 2 02/19/15, 21:11