Review main Merged

37025[BUGFIX] Install tool error message if session file not writeable

Christian Kuhn CR +2 V +2 Easy +16 −2 updated 02/19/15, 21:11

Commit message

In a rare case it may happen that the install tool created a session
file in typo3temp/InstallToolSessions and later those files can not
be written or updated due to permission problems.
The install tool then fails silently without error message.
Since write out of session data happens in __destruct() a proper
error message can not be created at this point anymore. Solution
is to "test write" the session file after opening it and throw
an exception if that fails.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
    • Frank Nägler +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1

Issues 1

Files 1

Review log 11

  1. Christian Kuhn uploaded patch set 1 02/19/15, 16:38

  2. Markus Klein commented on patch set 1 CR +1 V +1 02/19/15, 16:49

    makes sense! (no way to test for me here, so putting a blind v+1 here)
  3. Christian Kuhn commented on patch set 1 02/19/15, 16:59

    i'm still testing some scenarios here to make sure this patch is no problem.
  4. Markus Klein commented on patch set 1 02/19/15, 17:11

    btw: we need something similar for PHP session handling in general. I once had the issue of PHP not being able to write the session file. This causes failing logins to BE, but no error message. phpmyadmin revealed the issue to me back then.
  5. Wouter Wolters commented on patch set 1 02/19/15, 17:42

    SessionService.php:376

    Exception, short variant?

    SessionService.php:377

    subdirectories
  6. Christian Kuhn uploaded patch set 2 02/19/15, 18:22

  7. Christian Kuhn commented on patch set 2 02/19/15, 18:25

    Tested every scenario that came to my mind - including fresh install - with this patch applied now. Looks good to me.
  8. Markus Klein voted on patch set 2 CR +1 V +1 02/19/15, 19:58

  9. Frank Nägler voted on patch set 2 CR +1 02/19/15, 20:52

  10. Wouter Wolters voted on patch set 2 V +2 CR +2 02/19/15, 21:11

  11. Wouter Wolters merged patch set 2 02/19/15, 21:11