Review main Merged

37030[BUGFIX] Fix cookie evaluation order

Markus Klein CR +2 V +2 Easy +3 −24 updated 02/26/15, 16:27

Commit message

The workaround added for IE8 in #22084 is not needed any more
and removed without substitution.

This avoids problems with multiple cookies which might be sent
due to nested instances or due to moving an instance around in the
folder hierarchy.

Review

  • Code review CR +2
    • Markus Klein +2
    • Helmut Hummel +2
  • Verified V +2
    • Markus Klein +2
    • Helmut Hummel +1

Issues 1

Files 2

Review log 19

  1. Markus Klein uploaded patch set 1 02/20/15, 00:04

  2. Markus Klein updated the commit message in patch set 2 02/20/15, 00:10

  3. Christian Kuhn commented on patch set 2 02/20/15, 00:11

    Thank you so much Markus! This one needs a serious review - and maybe something about order is also stated in RFC?
  4. Markus Klein commented on patch set 2 02/20/15, 00:25

    see link in commit message and ticket ;-)
  5. Helmut Hummel commented on patch set 2 02/20/15, 08:55

    I would also say that we must cover this with tests. Unfortunately I have no time to do a serious review :/
  6. Markus Klein commented on patch set 2 CR -1 02/22/15, 00:08

    Ok according to the code comment this behviour - to fetch the first cookie - is due to a "bug" in IE with www and non-www domains. Curiously I'm not really sure if this really a bug of IE. http://stackoverflow.com/questions/2638344/ie-sends-multiple-cookies-with-same-name I give -1 here, because at least the comment needs to be adjusted. I'll try to find the original ticket for this code.
  7. Markus Klein commented on patch set 2 02/22/15, 00:58

    i posted some more things to the forge ticket. please have a look.
  8. Helmut Hummel uploaded patch set 3 02/22/15, 08:11

  9. Helmut Hummel commented on patch set 3 CR +2 02/22/15, 08:13

    To be sure to not break things, we should keep the (adapted) method when adding this patch to 6.2
  10. Helmut Hummel commented on patch set 3 V -1 CR -1 02/22/15, 08:17

    whoops. tests fail
  11. Helmut Hummel uploaded patch set 4 02/22/15, 08:22

  12. Helmut Hummel commented on patch set 4 CR +2 V +2 02/22/15, 08:30

    tests now pass again

    FunctionalTestCase.php:213

    unrelated fix. can go in a different change, but must go in.

    FunctionalTestCase.php:218

    hmm, this test fix shows how it can break, when removing the method. worth adding a specific change for 6.2 or do we just fix it in master?
  13. Markus Klein commented on patch set 4 CR +1 02/22/15, 10:40

    Thanks for the update Helmut!!

    FunctionalTestCase.php:213 Reply

    fine with me. easy to grasp ;-)

    FunctionalTestCase.php:218 Reply

    Actually I don't mind. Maybe master is enough. @Lolli what do you think?
  14. Helmut Hummel commented on patch set 4 CR -1 V -1 02/26/15, 15:17

    actually I missed one method call :(
  15. Helmut Hummel uploaded patch set 5 02/26/15, 15:21

  16. Helmut Hummel commented on patch set 5 CR +2 V +1 02/26/15, 15:22

    since the value from the cookie is needed in two places I left the getCookie in there in latest patch set
  17. Markus Klein voted on patch set 5 CR +2 V +2 02/26/15, 16:26

  18. Markus Klein merged patch set 5 02/26/15, 16:27

  19. Markus Klein commented on patch set 6 02/26/15, 16:27

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 0345088aee3f2bda1f84a5d877677cea63ee14a8