37030[BUGFIX] Fix cookie evaluation order
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Helmut Hummel +2
-
Verified V +2
- Markus Klein +2
- Helmut Hummel +1
Issues 1
Files 2
Review log 19
-
Markus Klein uploaded patch set 1 02/20/15, 00:04
-
Markus Klein updated the commit message in patch set 2 02/20/15, 00:10
-
Christian Kuhn commented on patch set 2 02/20/15, 00:11
Thank you so much Markus! This one needs a serious review - and maybe something about order is also stated in RFC? -
Markus Klein commented on patch set 2 02/20/15, 00:25
see link in commit message and ticket ;-) -
Helmut Hummel commented on patch set 2 02/20/15, 08:55
I would also say that we must cover this with tests. Unfortunately I have no time to do a serious review :/ -
Markus Klein commented on patch set 2 CR -1 02/22/15, 00:08
Ok according to the code comment this behviour - to fetch the first cookie - is due to a "bug" in IE with www and non-www domains. Curiously I'm not really sure if this really a bug of IE. http://stackoverflow.com/questions/2638344/ie-sends-multiple-cookies-with-same-name I give -1 here, because at least the comment needs to be adjusted. I'll try to find the original ticket for this code. -
Markus Klein commented on patch set 2 02/22/15, 00:58
i posted some more things to the forge ticket. please have a look. -
Helmut Hummel uploaded patch set 3 02/22/15, 08:11
-
Helmut Hummel commented on patch set 3 CR +2 02/22/15, 08:13
To be sure to not break things, we should keep the (adapted) method when adding this patch to 6.2 -
Helmut Hummel commented on patch set 3 V -1 CR -1 02/22/15, 08:17
whoops. tests fail -
Helmut Hummel uploaded patch set 4 02/22/15, 08:22
-
Helmut Hummel commented on patch set 4 CR +2 V +2 02/22/15, 08:30
tests now pass againFunctionalTestCase.php:213unrelated fix. can go in a different change, but must go in.FunctionalTestCase.php:218hmm, this test fix shows how it can break, when removing the method. worth adding a specific change for 6.2 or do we just fix it in master? -
Markus Klein commented on patch set 4 CR +1 02/22/15, 10:40
Thanks for the update Helmut!!FunctionalTestCase.php:213Replyfine with me. easy to grasp ;-)FunctionalTestCase.php:218ReplyActually I don't mind. Maybe master is enough. @Lolli what do you think? -
Helmut Hummel commented on patch set 4 CR -1 V -1 02/26/15, 15:17
actually I missed one method call :( -
Helmut Hummel uploaded patch set 5 02/26/15, 15:21
-
Helmut Hummel commented on patch set 5 CR +2 V +1 02/26/15, 15:22
since the value from the cookie is needed in two places I left the getCookie in there in latest patch set -
Markus Klein voted on patch set 5 CR +2 V +2 02/26/15, 16:26
-
Markus Klein merged patch set 5 02/26/15, 16:27
-
Markus Klein commented on patch set 6 02/26/15, 16:27
Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 0345088aee3f2bda1f84a5d877677cea63ee14a8