Review main Merged

37034[BUGFIX] AbstractTreeView correct permission handling with non pages

Andreas Allacher CR +2 V +2 Easy +3 −2 updated 04/21/15, 13:21

Commit message

AbstractTreeView now checks correctly, if a user has permission
to access elements even if they are not pages.

Without this change it was always assumed that the "uid" of the record
is the page uid. However, that is only valid for pages.

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Markus Klein +1
  • Verified V +2
    • Andreas Kienast +2
    • Markus Klein +1

Issues 1

Files 1

Review log 15

  1. Andreas Allacher uploaded patch set 1 02/20/15, 08:09

  2. Andreas Allacher uploaded patch set 2 02/20/15, 08:10

  3. Andreas Allacher voted on patch set 2 V +1 02/24/15, 09:04

  4. Andreas Allacher voted on patch set 2 V 0 02/24/15, 15:41

  5. Andreas Allacher uploaded patch set 3 02/24/15, 15:55

  6. Andreas Allacher updated the commit message in patch set 4 02/24/15, 18:25

  7. Wouter Wolters voted on patch set 4 CR +1 02/27/15, 22:59

  8. Markus Klein commented on patch set 4 04/13/15, 21:32

    Other than my comment I consider this change very valuable!
    Please describe what is changed and not the bug. Thanks
  9. Andreas Allacher updated the commit message in patch set 5 04/16/15, 19:27

  10. Markus Klein updated the commit message in patch set 6 04/19/15, 12:03

  11. Markus Klein commented on patch set 6 CR +1 V +1 04/19/15, 12:04

    AbstractTreeView.php:750

    no need for the extra ()
  12. Andreas Allacher commented on patch set 6 04/19/15, 19:17

    AbstractTreeView.php:750 Reply

    True. However, personally I think it makes it better readable (if the condition of the ? operator is in brackets). Of course, that is only my opinion.
  13. Andreas Kienast voted on patch set 6 CR +2 V +2 04/21/15, 13:21

  14. Andreas Kienast merged patch set 6 04/21/15, 13:21

  15. Andreas Kienast commented on patch set 7 04/21/15, 13:21

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit b2994efd568c9422f94d7c742a652cbb5f70330f