Review main Merged

37038[BUGFIX] Prevent deletion of closing bracket via INCLUDE_TYPOSCRIPT

Andreas Allacher CR +2 V +2 Easy +2 −2 updated 03/01/15, 14:45

Commit message

Due to missing check of the last char being a new line, it is
possible that a closing bracket character is removed by
using INCLUDE_TYPOSCRIPT.
This leads to broken typoscript.
By introducing the missing check this kind of error is prevented.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Benni Mack +1
  • Verified V +2
    • Christian Kuhn +2
    • Benni Mack +1

Issues 1

Files 1

Review log 19

  1. Andreas Allacher uploaded patch set 1 02/20/15, 09:24

  2. Andreas Allacher voted on patch set 1 V +1 02/24/15, 09:04

  3. Andreas Allacher voted on patch set 1 V 0 02/24/15, 15:41

  4. Andreas Allacher updated the commit message in patch set 2 02/24/15, 15:55

  5. Andreas Allacher updated the commit message in patch set 3 02/24/15, 18:26

  6. Frederic Gaus updated the commit message in patch set 4 02/25/15, 16:27

  7. Frederic Gaus voted on patch set 4 CR +1 V +1 02/25/15, 16:28

  8. Wouter Wolters voted on patch set 4 CR +1 02/27/15, 22:44

  9. Anja Leichsenring updated the commit message in patch set 5 02/28/15, 13:28

  10. Frans Saris voted on patch set 5 CR +1 03/01/15, 12:17

  11. Christian Kuhn updated the commit message in patch set 6 03/01/15, 12:36

  12. Christian Kuhn voted on patch set 6 CR +1 V +1 03/01/15, 12:37

  13. Frans Saris voted on patch set 6 CR +1 03/01/15, 12:46

  14. Benni Mack uploaded patch set 7 03/01/15, 14:01

  15. Benni Mack voted on patch set 7 CR +1 V +1 03/01/15, 14:01

  16. Christian Kuhn voted on patch set 7 CR +1 V +1 03/01/15, 14:18

  17. Wouter Wolters voted on patch set 7 CR +1 03/01/15, 14:35

  18. Christian Kuhn voted on patch set 7 CR +2 V +2 03/01/15, 14:45

  19. Christian Kuhn merged patch set 7 03/01/15, 14:45