Review main Merged

3704[BUGFIX] Error when opening TYPO3 manual

Markus Klein CR +2 V +2 Easy +6 −1 updated 06/03/13, 20:49

Commit message

A missing parameter for SC_view_help::render_Table() causes
TYPO3 manual to produce a PHP warning.
This patch makes the second parameter optional.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Philipp Gampe +1
  • Verified V +2
    • Christian Kuhn +2
    • Philipp Gampe +1

Issues 1

Files 1

Review log 8

  1. Markus Klein commented on patch set 2 07/31/11, 15:22

    (1 inline comment)
  2. Markus Klein uploaded patch set 2 07/31/11, 15:22

  3. Georg Ringer commented on patch set 2 07/31/11, 15:22

    (1 inline comment)

    view_help.php:412

    it it is a string, use $table = '' and later on if(empty($table)
  4. Philipp Gampe commented on patch set 2 07/31/11, 15:22

    Verified; Looks good to me, but someone else must approve does not break anything and change makes sense
  5. Mr. Jenkins commented on patch set 1 07/31/11, 15:22

  6. Mr. Jenkins commented on patch set 2 07/31/11, 15:22

  7. Christian Kuhn commented on patch set 2 V 0 1 comment 07/31/11, 15:22

    by team member; Looks good to me, approved The patch is straight and solves the problem for now. Merged.
  8. Christian Kuhn merged patch set 2 07/31/11, 15:22