Review TYPO3_6-2 Merged

37042[BUGFIX] Keep image order during upgrade

Nicole Hummel CR +2 V +2 Easy +3 −1 updated 02/21/15, 13:43

Commit message

After upgrading from 4.5 to 6.2 the image sorting is messed. This patch
adds sorting rows to file references to keep the correct order. The sort
interval matches the default value of DataHandler.

Review

  • Code review CR +2
    • Markus Klein +2
  • Verified V +2
    • Markus Klein +2
    • Philipp Müller +1

Issues 1

Files 1

Review log 9

  1. Nicole Hummel uploaded patch set 1 02/20/15, 11:30

  2. Helmut Hummel voted on patch set 1 CR +1 02/20/15, 11:38

  3. Markus Klein commented on patch set 1 02/20/15, 11:53

    TceformsUpdateWizard.php:355

    Please explain in the commit message where the magic 256 comes from.
  4. Nicole Hummel uploaded patch set 2 02/20/15, 11:59

  5. Nicole Hummel uploaded patch set 3 02/20/15, 12:53

  6. Markus Klein voted on patch set 3 CR +1 02/20/15, 13:40

  7. Philipp Müller commented on patch set 3 V +1 02/20/15, 13:58

    works for me
  8. Markus Klein commented on patch set 3 CR +2 V +2 02/21/15, 13:42

    Will merge this one straight now as the chance for more reviewers is close to zero
  9. Markus Klein merged patch set 3 02/21/15, 13:43