37046[TASK] Enable clipboard by default
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
- Mathias Schreiber +1
- Benjamin Kott +1
- Michael Oehlhof +1
- Nicole Hummel +1
-
Verified V +2
- Jigal van Hemert +2
- Mathias Schreiber +1
- Benjamin Kott +1
- Michael Oehlhof +1
Issues 1
Files 1
Review log 16
-
Andreas Kienast uploaded patch set 1 02/20/15, 13:52
-
Sascha Egerer commented on patch set 1 02/20/15, 14:04
-
Andreas Kienast commented on patch set 1 V -1 02/20/15, 14:20
RecordList.php:283ReplyOf course, pushing a new patch -
Andreas Kienast uploaded patch set 2 02/20/15, 14:25
-
Sascha Egerer commented on patch set 2 CR -1 02/20/15, 14:35
RecordList.php:289Again I've not checked the logic here but for me these conditions look a little bit useless. Wouldn't it make sense to set "$this->MOD_SETTINGS['clipBoard'] = TRUE;" on line 281 which would be the default then? That will be overwritten if $this->modTSconfig['properties']['enableClipBoard'] is 'deactivated'. The 'activacted' condition can then also be removed. As already said i'm not sure if this would end in any unexpected behavior. -
Andreas Kienast commented on patch set 2 02/20/15, 14:39
RecordList.php:289ReplyWell, the else is entered only if enableClipBoard is neither activated not deactivated, which is UserTS. The third state is "selectable" and the default. If you (un)check the checkbox, it's still "selectable", so putting "$this->MOD_SETTINGS['clipBoard'] = TRUE;" on top would break this. -
Mathias Schreiber commented on patch set 2 CR +1 V +1 02/20/15, 14:48
Works as expected. To test: UPDATE be_users SET uc = '' :) -
Sascha Egerer voted on patch set 2 CR 0 02/20/15, 14:49
-
Benjamin Kott voted on patch set 2 CR +1 V +1 02/20/15, 17:34
-
Michael Oehlhof voted on patch set 2 CR +1 V +1 02/20/15, 21:44
-
Nicole Hummel commented on patch set 2 CR +1 02/20/15, 21:56
RecordList.php:289ReplyI think this would overwrite a deactivated clip board then. -
Michael Oehlhof commented on patch set 2 02/20/15, 22:05
RecordList.php:289ReplyI don't think so. Deactivated clipboard is FALSE. I've CherryPick and for a user with deactivated clipboard it was deactivated. Then I switched to a new user and the clipboard was shown as default. -
Nicole Hummel commented on patch set 2 02/20/15, 22:15
RecordList.php:289Reply@Michael: Sorry, this was the answer for @Sascha ;-) -
Jigal van Hemert commented on patch set 2 CR +2 V +2 02/22/15, 20:15
Already enough votes. Plus: it works :-) -
Jigal van Hemert merged patch set 2 02/22/15, 20:15
-
Philipp Gampe commented on patch set 3 02/22/15, 22:17
this one misses documentation
RecordList.php:283