37063[TASK] Streamline page position map
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Nicole Hummel +1
-
Verified V +2
- Wouter Wolters +2
- Nicole Hummel +1
Issues 1
Files 6
- typo3/sysext/backend/Classes/Controller/ContentElement/NewContentElementController.php+3 −9
- typo3/sysext/backend/Classes/Tree/View/PagePositionMap.php7+40 −16
- typo3/sysext/t3skin/Resources/Private/Styles/TYPO3/structure/_element_move_element.lessdeleted+0 −19
- typo3/sysext/t3skin/Resources/Private/Styles/TYPO3/_element_table.less+37 −1
- typo3/sysext/t3skin/Resources/Private/Styles/t3skin.less+0 −1
- typo3/sysext/t3skin/Resources/Public/Css/visual/t3skin.css+26 −15
Review log 14
-
Benjamin Kott uploaded patch set 1 02/21/15, 00:50
-
Markus Klein updated the commit message in patch set 2 02/21/15, 11:59
-
Felix Kopp commented on patch set 2 V +1 02/21/15, 12:15
BRs should be remove - good to be able to remove the move element custom styles. Good I still think the "New Content Element" wizard should not show be styled as a tree but just a simple panel/button list. There is no hierarchy involved when adding content. Makes sense to be able to remove the custom css! -
Markus Klein commented on patch set 2 02/21/15, 12:23
PagePositionMap.php:449missing space after foreachPagePositionMap.php:463$row is undefined here!PagePositionMap.php:467missing space after foreach -
Benjamin Kott uploaded patch set 3 02/21/15, 12:49
-
Benjamin Kott commented on patch set 2 02/21/15, 12:50
PagePositionMap.php:449ReplyDonePagePositionMap.php:463ReplyDonePagePositionMap.php:467ReplyDone -
Benjamin Kott commented on patch set 3 02/21/15, 12:55
@felix we should have a look at the new content element wizard tree thingy in a seperate patch. We also have to touch the css tree again - its a but unhandy in use. -
Nicole Hummel voted on patch set 3 V +1 CR +1 02/21/15, 13:12
-
Wouter Wolters commented on patch set 3 02/21/15, 13:12
PagePositionMap.php:464space after if -
Wouter Wolters uploaded patch set 4 02/21/15, 13:16
-
Wouter Wolters voted on patch set 4 V +1 CR +1 02/21/15, 13:16
-
Nicole Hummel voted on patch set 4 CR +1 V +1 02/21/15, 13:17
-
Wouter Wolters voted on patch set 4 V +2 CR +2 02/21/15, 13:19
-
Wouter Wolters merged patch set 4 02/21/15, 13:19