Review main Merged

37063[TASK] Streamline page position map

Benjamin Kott CR +2 V +2 Normal +106 −61 updated 02/21/15, 13:19

Commit message

- Reduce usage of custom CSS in page position map
  for inserting/moving content elements.
- Add missing language file
- Remove unused CSS

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Nicole Hummel +1
  • Verified V +2
    • Wouter Wolters +2
    • Nicole Hummel +1

Issues 1

Files 6

Review log 14

  1. Benjamin Kott uploaded patch set 1 02/21/15, 00:50

  2. Markus Klein updated the commit message in patch set 2 02/21/15, 11:59

  3. Felix Kopp commented on patch set 2 V +1 02/21/15, 12:15

    BRs should be remove - good to be able to remove the move element custom styles. Good I still think the "New Content Element" wizard should not show be styled as a tree but just a simple panel/button list. There is no hierarchy involved when adding content. Makes sense to be able to remove the custom css!
  4. Markus Klein commented on patch set 2 02/21/15, 12:23

    PagePositionMap.php:449

    missing space after foreach

    PagePositionMap.php:463

    $row is undefined here!

    PagePositionMap.php:467

    missing space after foreach
  5. Benjamin Kott uploaded patch set 3 02/21/15, 12:49

  6. Benjamin Kott commented on patch set 2 02/21/15, 12:50

    PagePositionMap.php:449 Reply

    Done

    PagePositionMap.php:463 Reply

    Done

    PagePositionMap.php:467 Reply

    Done
  7. Benjamin Kott commented on patch set 3 02/21/15, 12:55

    @felix we should have a look at the new content element wizard tree thingy in a seperate patch. We also have to touch the css tree again - its a but unhandy in use.
  8. Nicole Hummel voted on patch set 3 V +1 CR +1 02/21/15, 13:12

  9. Wouter Wolters commented on patch set 3 02/21/15, 13:12

    PagePositionMap.php:464

    space after if
  10. Wouter Wolters uploaded patch set 4 02/21/15, 13:16

  11. Wouter Wolters voted on patch set 4 V +1 CR +1 02/21/15, 13:16

  12. Nicole Hummel voted on patch set 4 CR +1 V +1 02/21/15, 13:17

  13. Wouter Wolters voted on patch set 4 V +2 CR +2 02/21/15, 13:19

  14. Wouter Wolters merged patch set 4 02/21/15, 13:19