Review main Merged

37089[BUGFIX] Browse for records in edit document popup works again

Michael Oehlhof CR +2 V +2 Easy +17 −3 updated 02/28/15, 17:34

Commit message

When editing a group in the edit document popup the browse for records
button was without function, this is now fixed.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Wouter Wolters +1
    • Markus Klein +1
  • Verified V +2
    • Anja Leichsenring +2
    • Wouter Wolters +1

Issues 1

Files 2

Review log 11

  1. Michael Oehlhof uploaded patch set 1 02/22/15, 02:08

  2. Wouter Wolters updated the commit message in patch set 2 02/23/15, 19:02

  3. Wouter Wolters commented on patch set 2 02/23/15, 19:02

    See forge item for how to reproduce.
  4. Markus Klein commented on patch set 2 02/23/15, 19:06

    EditDocumentController.php:670

    Assign the default as first statement above. Then do the if (!empty($popupWindowSize)) { and use intExplode();
  5. Michael Oehlhof commented on patch set 2 02/24/15, 10:23

    EditDocumentController.php:670 Reply

    Should we chnge this also in BackendController.php Line 500 from where I get this code?
  6. Markus Klein commented on patch set 2 02/24/15, 10:34

    EditDocumentController.php:670 Reply

    Oh, yes I'd say so then
  7. Michael Oehlhof uploaded patch set 3 02/24/15, 11:11

  8. Markus Klein voted on patch set 3 CR +1 02/24/15, 14:57

  9. Wouter Wolters voted on patch set 3 V +1 CR +1 02/27/15, 23:03

  10. Anja Leichsenring commented on patch set 3 CR +2 V +2 02/28/15, 17:28

  11. Anja Leichsenring merged patch set 3 02/28/15, 17:34