37153[BUGFIX] Allow closures in filters methods for directory items
Commit message
Review
-
Code review CR +2
- Nicole Hummel +2
- Christian Kuhn +1
-
Verified V +2
- Nicole Hummel +2
- Christian Kuhn +1
Issues 1
Files 2
Review log 20
-
Christoph Dörfel uploaded patch set 1 02/24/15, 07:26
-
Frans Saris updated the commit message in patch set 2 02/24/15, 08:56
-
Frans Saris voted on patch set 2 CR +1 02/24/15, 08:56
-
Markus Klein voted on patch set 2 CR +1 02/24/15, 08:58
-
Nicole Hummel commented on patch set 2 02/24/15, 09:00
What about adding unit tests here? -
Frans Saris commented on patch set 2 02/24/15, 09:11
@Nicole that would indeed be a good addition. Christoph could you take care of that? Please let us know if you need help with that. -
Christoph Dörfel commented on patch set 2 02/24/15, 09:44
I can take care of that, just need a bit more time (I'm booked ;) ) -
Markus Klein commented on patch set 2 04/13/15, 21:28
ping -
Christoph Dörfel commented on patch set 2 04/15/15, 07:02
> ping About the unit tests: I still haven't found the time to look at them. Checking my calendar I don't see this happening until end of May :( If someone else wants to contribute, please feel free to do so. -
Susi Moog uploaded patch set 3 05/10/15, 18:10
-
Susi Moog commented on patch set 3 05/10/15, 18:10
Added two very basic tests for the method. -
Nicole Hummel uploaded patch set 4 05/10/15, 20:37
-
Nicole Hummel voted on patch set 4 CR +1 V +1 05/10/15, 20:37
-
Christian Kuhn voted on patch set 4 CR +1 V +1 05/11/15, 11:05
-
Christian Kuhn voted on patch set 4 CR 0 V 0 05/11/15, 11:08
-
Christian Kuhn uploaded patch set 5 05/11/15, 11:10
-
Christian Kuhn commented on patch set 5 CR +1 V +1 05/11/15, 11:11
thx, especially for the tests :) Just changed file permissions of the test file back to 644, they were accidently changed to 755 somehow. -
Nicole Hummel voted on patch set 5 CR +2 V +2 05/11/15, 12:30
-
Nicole Hummel merged patch set 5 05/11/15, 12:30
-
Nicole Hummel commented on patch set 6 05/11/15, 12:31
Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 242c437d073177d582f29966e3c2eba1f5ff459a