Review main Merged

37153[BUGFIX] Allow closures in filters methods for directory items

Christoph Dörfel CR +2 V +2 Easy +37 −1 updated 05/11/15, 12:31

Commit message

Instead of checking if a given filter is callable a is_array check
is done. But the filter can also be a closure and a is_array would
fail then.

This patch changes the is_array check to is_callable.

Review

  • Code review CR +2
    • Nicole Hummel +2
    • Christian Kuhn +1
  • Verified V +2
    • Nicole Hummel +2
    • Christian Kuhn +1

Issues 1

Files 2

Review log 20

  1. Christoph Dörfel uploaded patch set 1 02/24/15, 07:26

  2. Frans Saris updated the commit message in patch set 2 02/24/15, 08:56

  3. Frans Saris voted on patch set 2 CR +1 02/24/15, 08:56

  4. Markus Klein voted on patch set 2 CR +1 02/24/15, 08:58

  5. Nicole Hummel commented on patch set 2 02/24/15, 09:00

    What about adding unit tests here?
  6. Frans Saris commented on patch set 2 02/24/15, 09:11

    @Nicole that would indeed be a good addition. Christoph could you take care of that? Please let us know if you need help with that.
  7. Christoph Dörfel commented on patch set 2 02/24/15, 09:44

    I can take care of that, just need a bit more time (I'm booked ;) )
  8. Markus Klein commented on patch set 2 04/13/15, 21:28

    ping
  9. Christoph Dörfel commented on patch set 2 04/15/15, 07:02

    > ping About the unit tests: I still haven't found the time to look at them. Checking my calendar I don't see this happening until end of May :( If someone else wants to contribute, please feel free to do so.
  10. Susi Moog uploaded patch set 3 05/10/15, 18:10

  11. Susi Moog commented on patch set 3 05/10/15, 18:10

    Added two very basic tests for the method.
  12. Nicole Hummel uploaded patch set 4 05/10/15, 20:37

  13. Nicole Hummel voted on patch set 4 CR +1 V +1 05/10/15, 20:37

  14. Christian Kuhn voted on patch set 4 CR +1 V +1 05/11/15, 11:05

  15. Christian Kuhn voted on patch set 4 CR 0 V 0 05/11/15, 11:08

  16. Christian Kuhn uploaded patch set 5 05/11/15, 11:10

  17. Christian Kuhn commented on patch set 5 CR +1 V +1 05/11/15, 11:11

    thx, especially for the tests :) Just changed file permissions of the test file back to 644, they were accidently changed to 755 somehow.
  18. Nicole Hummel voted on patch set 5 CR +2 V +2 05/11/15, 12:30

  19. Nicole Hummel merged patch set 5 05/11/15, 12:30

  20. Nicole Hummel commented on patch set 6 05/11/15, 12:31

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 242c437d073177d582f29966e3c2eba1f5ff459a