37154[FEATURE] allow aliases for switchableControllerActions in Flexform
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 5
- typo3/sysext/core/Documentation/Changelog/master/Feature-65245-ExtbaseSwitchableControllerActionsInFlexformShouldAllowAlias.rstnew+26 −0
- typo3/sysext/extbase/Classes/Configuration/FrontendConfigurationManager.php+38 −9
- typo3/sysext/extbase/Classes/Utility/ExtensionUtility.php+28 −0
- typo3/sysext/extbase/Tests/Unit/Configuration/FrontendConfigurationManagerTest.php+54 −0
- typo3/sysext/extbase/Tests/Unit/Utility/ExtensionUtilityTest.php+84 −0
Review log 21
-
Andreas Allacher uploaded patch set 1 02/24/15, 07:43
-
Andreas Allacher commented on patch set 1 02/24/15, 07:46
This is a possible solution to the corresponding ticket, maybe there would be better ways to do this. In this case one would add e.g. "ALIAS:detailAlias" in Flexforms switchableControllerActions to be stored and use this method to add the corresponding Alias in ext_localconf.php \TYPO3\CMS\Extbase\Utility\ExtensionUtility::addFlexFormSwitchableControllerActionsAlias( $_EXTKEY, 'Controller', 'detailAlias', array( 'Controller' => 'action1,action2', ) ); -
Andreas Allacher voted on patch set 1 V +1 02/24/15, 07:49
-
Andreas Allacher uploaded patch set 2 02/24/15, 15:37
-
Andreas Allacher uploaded patch set 3 02/24/15, 15:38
-
Andreas Allacher uploaded patch set 4 02/24/15, 15:40
-
Andreas Allacher uploaded patch set 5 02/26/15, 13:25
-
Andreas Allacher uploaded patch set 6 02/26/15, 13:27
-
Andreas Allacher uploaded patch set 7 02/26/15, 13:30
-
Christian Kuhn commented on patch set 7 02/26/15, 15:12
Frankly, I'm not a big fan of the SwitchableControllerActions in the first place. Imho, the concept is flawed and we're not using it at all in our plugins. I'd rather deprecate the whole approach than circumventing the "it is broken if i add / remove actions for existing elements" with an alias approach or something alike. Maybe we system can be given further thoughts if we improve the whole plugin and registration and display later. -
Andreas Allacher commented on patch set 7 02/26/15, 16:57
Personally, I try to avoid using them too. However, one can also use switchableControllerActions in TypoScript where it actually makes sense. And there are already Extensions that use it. This way it is a no breaking change and it is usable also via Flexform. However, maybe it would be better to no control switchableControllerActions via Flexform but via a grouping option when configuring the plugin and the Backend itself provides the "switch" option. -
Andreas Allacher commented on patch set 7 02/26/15, 17:02
If we deprecate it, all Extensions that use that feature will be required to change all their plugins that are already stored. So either we add a completely new "possibility" or use this feature or something similiar. -
Andreas Allacher commented on patch set 7 02/26/15, 17:17
Ah I forgot to mention: I am still for adding this feature. If there are different approaches later on that can still be added and this makes swtichableControllerActions way more usable until that is the case. -
Andreas Allacher commented on patch set 7 02/26/15, 17:28
There is no edit button for comments is there? Also I don't think deprecating the whole thing is a good idea because I think quite a lot of Plugins/Extensions already use this system which would create a lot of required updates in database and extensions which cannot be automated. So if there is anything new I would add it additionally to this system. -
Andreas Allacher uploaded patch set 8 02/27/15, 06:19
-
Andreas Allacher uploaded patch set 9 02/27/15, 06:35
-
Anja Leichsenring commented on patch set 9 CR -1 03/02/15, 20:18
I opt for abandoning this patch, because there is no gain in fixing a broken approach. This whole flexform/switchableControllerAction stuff needs to rethought and receive a proper concept. -
Christian Kuhn voted on patch set 9 CR -1 03/02/15, 20:24
-
Helmut Hummel commented on patch set 9 CR -2 03/02/15, 20:29
Thank you for your suggestion to improve Extbase Plugin handling. I however agree with Anja and Christian that we should rather work on a new concept which solves all requirements than making a flawed concept even more complicated and less understandable. If we then at some point deprecated switchableControllerActions or not can be decided once we implemented the alternative concept. Fo kickstarting a concept, I suggest to write a blueprint (http://wiki.typo3.org/Blueprints) and ask for feedback in the forum/ on mailing lists. I'm looking forward to read your suggestions. -
Helmut Hummel abandoned the change 03/02/15, 20:30
I will abandon this change request and close the ticket as there is agreement to not follow this path -
Andy Grunwald commented on patch set 9 05/15/15, 16:34
Github tests: success Pull request: https://github.com/typo3-ci/TYPO3.CMS-pre-merge-tests/pull/91 Service: continuous-integration/travis-ci/push Description: The Travis CI build passed URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/52382500