Review main Merged

37156[BUGFIX] Let Scheduler handle storage indexing exception

Francois Suter CR +2 V +2 Easy +2 −9 updated 03/01/15, 19:22

Commit message

The FileStorageIndexingTask should not handle exceptions itself.
Instead it should let them bubble up to let the Scheduler take
care of the reporting.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1

Issues 1

Files 1

Review log 9

  1. Francois Suter uploaded patch set 1 02/24/15, 09:10

  2. Wouter Wolters voted on patch set 1 CR +1 02/27/15, 22:58

  3. Wouter Wolters uploaded patch set 2 03/01/15, 15:41

  4. Wouter Wolters commented on patch set 1 03/01/15, 15:41

    FileStorageIndexingTask.php:35

    can be removed, return TRUE directly
  5. Wouter Wolters voted on patch set 2 V +1 CR +1 03/01/15, 15:41

  6. Christian Kuhn voted on patch set 2 CR +2 V +2 03/01/15, 17:53

  7. Christian Kuhn merged patch set 2 03/01/15, 17:53

  8. Christian Kuhn commented on patch set 3 03/01/15, 17:53

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 972bd0e86bee105af61f4e1e09de37e65bc5a44c
  9. Francois Suter commented on patch set 3 03/01/15, 19:22

    Thanks for taking care!