37186[TASK] Make show_item.php dispatched
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Christian Kuhn +1
-
Verified V +2
- Anja Leichsenring +2
- Christian Kuhn +1
Issues 1
Files 10
- typo3/sysext/backend/Classes/Controller/BackendController.php+3 −0
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php4+1 −1
- typo3/sysext/backend/Modules/ShowItem/conf.phpnew+4 −0
- typo3/sysext/backend/Modules/ShowItem/index.phpnew+19 −0
- typo3/sysext/backend/Resources/Public/JavaScript/backend.js+1 −2
- typo3/sysext/backend/ext_tables.php+6 −0
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-65283-DeprecateShowItemEntryPoint.rstnew+25 −0
- typo3/sysext/recordlist/Classes/Browser/ElementBrowser.php3+1 −1
- typo3/sysext/rtehtmlarea/Classes/BrowseLinks.php3+1 −1
- typo3/show_item.php1+4 −0
Review log 17
-
Wouter Wolters uploaded patch set 1 02/24/15, 20:32
-
Wouter Wolters updated the commit message in patch set 2 02/24/15, 20:33
-
Wouter Wolters uploaded patch set 3 02/24/15, 20:34
-
Helmut Hummel commented on patch set 3 CR -1 02/25/15, 19:50
Looks good in general. Thanks a lot Wouter for cleaning up these entry points, highly appreciated! I have a few minor remarks however …EditDocumentController.php:680since the backPath is taken care of in JS, we should probably pass '' as backPath to getModuleUrlElementBrowser.php:745we could skip $GLOBALS['BACK_PATH'] completely here, as it is the default when calling BackendUtility::getModuleUrl() without this parameterBrowseLinks.php:406we could skip $GLOBALS['BACK_PATH'] completely here, as it is the default when calling BackendUtility::getModuleUrl() without this parameter -
Wouter Wolters commented on patch set 3 02/26/15, 07:48
EditDocumentController.php:680ReplyDoneElementBrowser.php:745ReplyDoneBrowseLinks.php:406ReplyDone -
Wouter Wolters uploaded patch set 4 02/26/15, 07:48
-
Helmut Hummel commented on patch set 4 CR -1 02/26/15, 10:10
Still a small mistake in one changeEditDocumentController.php:680no, this is wrong. Should be: GeneralUtility::quoteJSvalue(BackendUtility::getModuleUrl('show_item', array(), '') . '&table') currently you pass the additional arguments to ::quoteJSValue -
Helmut Hummel commented on patch set 4 02/26/15, 10:12
BTW. Once all entry points are removed, we can finally get rid of BACK_PATH altogether! (or maybe deprecate it first) -
Wouter Wolters uploaded patch set 5 02/26/15, 10:13
-
Helmut Hummel commented on patch set 5 CR -1 02/26/15, 23:21
EditDocumentController.php:680same here, the = is missing after tableElementBrowser.php:745ah, sorry missed that before that it must be '&table=' ( the = is missing)BrowseLinks.php:406... and here: table= -
Wouter Wolters uploaded patch set 6 02/26/15, 23:24
-
Markus Klein commented on patch set 6 02/26/15, 23:27
show_item.php:18Not entirely a correct sentence ;-) -
Helmut Hummel commented on patch set 6 CR +2 02/27/15, 10:38
Looks good now, thanks. Maybe fix Markus' remark before merge -
Wouter Wolters uploaded patch set 7 02/27/15, 22:06
-
Christian Kuhn voted on patch set 7 CR +1 V +1 03/01/15, 10:35
-
Anja Leichsenring voted on patch set 7 CR +2 V +2 03/01/15, 10:49
-
Anja Leichsenring merged patch set 7 03/01/15, 10:49