Review main Merged

37186[TASK] Make show_item.php dispatched

Wouter Wolters CR +2 V +2 Normal +65 −5 updated 03/01/15, 10:49

Commit message

Use dispatching for show_item.php

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Christian Kuhn +1

Issues 1

Files 10

Review log 17

  1. Wouter Wolters uploaded patch set 1 02/24/15, 20:32

  2. Wouter Wolters updated the commit message in patch set 2 02/24/15, 20:33

  3. Wouter Wolters uploaded patch set 3 02/24/15, 20:34

  4. Helmut Hummel commented on patch set 3 CR -1 02/25/15, 19:50

    Looks good in general. Thanks a lot Wouter for cleaning up these entry points, highly appreciated! I have a few minor remarks however …

    EditDocumentController.php:680

    since the backPath is taken care of in JS, we should probably pass '' as backPath to getModuleUrl

    ElementBrowser.php:745

    we could skip $GLOBALS['BACK_PATH'] completely here, as it is the default when calling BackendUtility::getModuleUrl() without this parameter

    BrowseLinks.php:406

    we could skip $GLOBALS['BACK_PATH'] completely here, as it is the default when calling BackendUtility::getModuleUrl() without this parameter
  5. Wouter Wolters commented on patch set 3 02/26/15, 07:48

    EditDocumentController.php:680 Reply

    Done

    ElementBrowser.php:745 Reply

    Done

    BrowseLinks.php:406 Reply

    Done
  6. Wouter Wolters uploaded patch set 4 02/26/15, 07:48

  7. Helmut Hummel commented on patch set 4 CR -1 02/26/15, 10:10

    Still a small mistake in one change

    EditDocumentController.php:680

    no, this is wrong. Should be: GeneralUtility::quoteJSvalue(BackendUtility::getModuleUrl('show_item', array(), '') . '&table') currently you pass the additional arguments to ::quoteJSValue
  8. Helmut Hummel commented on patch set 4 02/26/15, 10:12

    BTW. Once all entry points are removed, we can finally get rid of BACK_PATH altogether! (or maybe deprecate it first)
  9. Wouter Wolters uploaded patch set 5 02/26/15, 10:13

  10. Helmut Hummel commented on patch set 5 CR -1 02/26/15, 23:21

    EditDocumentController.php:680

    same here, the = is missing after table

    ElementBrowser.php:745

    ah, sorry missed that before that it must be '&table=' ( the = is missing)

    BrowseLinks.php:406

    ... and here: table=
  11. Wouter Wolters uploaded patch set 6 02/26/15, 23:24

  12. Markus Klein commented on patch set 6 02/26/15, 23:27

    show_item.php:18

    Not entirely a correct sentence ;-)
  13. Helmut Hummel commented on patch set 6 CR +2 02/27/15, 10:38

    Looks good now, thanks. Maybe fix Markus' remark before merge
  14. Wouter Wolters uploaded patch set 7 02/27/15, 22:06

  15. Christian Kuhn voted on patch set 7 CR +1 V +1 03/01/15, 10:35

  16. Anja Leichsenring voted on patch set 7 CR +2 V +2 03/01/15, 10:49

  17. Anja Leichsenring merged patch set 7 03/01/15, 10:49