Review main Merged

37196[BUGFIX] BE: DatabaseTreeDataProvider maxLevels incorrect

Andreas Allacher CR +2 V +2 Normal +145 −7 updated 05/20/15, 12:47

Commit message

The current behaviour for maxLevels with treeConfig is incorrect.
Currently if one uses maxLevels 0, instead of only seeing the root category,
one actually is presented of nodes up to level 2
(if one would specify the levels in nonSelectableLevels).
With maxLevels 1 it is already up to level 3.
Of course, maxLevels 0 should only display the root level, maxLevels 1 only the first child nodes.
Also increased default levelMaximum to 4, in order to ensure old non configured
trees are still behaving as intended.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +1

Issues 1

Files 3

Review log 15

  1. Andreas Allacher uploaded patch set 1 02/25/15, 07:46

  2. Alexander Opitz voted on patch set 1 V +1 CR +1 02/25/15, 09:29

  3. Helmut Hummel commented on patch set 1 02/25/15, 10:59

    can we get tests for that change please?
  4. Andreas Allacher uploaded patch set 2 02/26/15, 12:10

  5. Andreas Allacher uploaded patch set 3 02/26/15, 12:14

  6. Andreas Allacher uploaded patch set 4 02/26/15, 12:16

  7. Andreas Allacher commented on patch set 4 02/26/15, 12:32

    Added test regarding this. Not sure this is the best way on how to test this though.
  8. Andy Grunwald commented on patch set 4 05/15/15, 16:34

    Github tests: success Pull request: https://github.com/typo3-ci/TYPO3.CMS-pre-merge-tests/pull/90 Service: continuous-integration/travis-ci/push Description: The Travis CI build passed URL: https://travis-ci.org/typo3-ci/TYPO3.CMS-pre-merge-tests/builds/52265787
  9. Wouter Wolters uploaded patch set 5 05/19/15, 21:44

  10. Wouter Wolters commented on patch set 5 05/19/15, 21:45

    Will add 2 examples to test this with ext:styleguide soon
  11. Christian Kuhn commented on patch set 5 CR +1 V +1 05/20/15, 12:33

    stumbled upon this too, recently. thx for the patch! wouter added 2 examples to ext:styleguide to show this (select tab bottom)
  12. Christian Kuhn uploaded patch set 6 05/20/15, 12:37

  13. Christian Kuhn commented on patch set 6 CR +1 V +1 05/20/15, 12:38

    no change with latest push ...
  14. Wouter Wolters voted on patch set 6 V +2 CR +2 05/20/15, 12:47

  15. Wouter Wolters merged patch set 6 05/20/15, 12:47