Review TYPO3_6-2 Merged

37211[BUGFIX] File must use MIME type from index record

Andreas Wolf CR +2 V +2 Easy +20 −1 updated 03/01/15, 21:22

Commit message

The MIME type is stored in a field "mimetype" in the drivers, while the
field is called "mime_type" in the database. As the file object deals
with both when retrieving the type, it must respect this mismatch.

Review

  • Code review CR +2
    • Markus Klein +2
    • Wouter Wolters +1
  • Verified V +2
    • Markus Klein +2
    • Wouter Wolters +1

Issues 1

Files 2

Review log 8

  1. Andreas Wolf uploaded patch set 1 02/25/15, 13:02

  2. Markus Klein commented on patch set 1 02/25/15, 13:37

    AbstractFileTest.php:58

    ResourceStorage::class
  3. Markus Klein commented on patch set 1 02/25/15, 13:39

    AbstractFileTest.php:58 Reply

    Fine for 6.2 though
  4. Markus Klein commented on patch set 1 CR -2 02/25/15, 13:39

    blocked until master patch is merged
  5. Wouter Wolters commented on patch set 1 V +1 CR +1 02/28/15, 16:40

    master is merged, please remove -2
  6. Markus Klein voted on patch set 1 CR 0 03/01/15, 21:22

  7. Markus Klein voted on patch set 1 CR +2 V +2 03/01/15, 21:22

  8. Markus Klein merged patch set 1 03/01/15, 21:22