Review main Merged Breaking

37235[!!!][TASK] Deprecate typo3conf/extTables.php functionality

Benni Mack CR +2 V +2 Normal +39 −106 updated 05/22/15, 17:42

Commit message

Using typo3conf/extTables.php for TCA overrides is bad practice.
Nowadays, stuff like that should reside in an extension that
uses Configuration/TCA/Overrides.

The patch deprecates the according parameters and logs if
an instance still has an typo3conf/extTables.php file.

The functionality within lowlevel "Configuration" backend
module to write overrides to this file is removed.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +1

Issues 1

Files 7

Review log 15

  1. Benni Mack uploaded patch set 1 02/25/15, 17:06

  2. Mathias Brodala uploaded patch set 2 02/26/15, 07:17

  3. Mathias Brodala commented on patch set 2 02/26/15, 07:19

    First stab at a documentation.
  4. Benni Mack commented on patch set 2 02/28/15, 17:27

    FYI: Lolli suggested we should deprecate the functionality rather than kicking it directly.
  5. Jigal van Hemert commented on patch set 2 02/28/15, 20:27

    Nice cleanup! Probably needs to be deprecated, but we can kick the option to save settings to extTables.php directly!
  6. Frans Saris commented on patch set 2 03/01/15, 11:56

    +1 for deprecating extTables.php first and dropping the saveTo functionality now
  7. Stephan Großberndt commented on patch set 2 V -1 03/02/15, 14:42

    Not everyone modifying tables creates an extension to do so. At least until now. This must not be removed in CMS 7.
  8. Mathias Brodala commented on patch set 2 03/02/15, 15:01

    Well, the point of this change is to let developers/integrators know, how to properly do this. I'm fine with deprecation warnings in 7.x and removing it with 8.x though.
  9. Christian Kuhn commented on patch set 2 CR -1 03/02/15, 20:39

    Yeah. I think we need to deprecate this somehow.
  10. Andy Grunwald commented on patch set 2 V -1 05/15/15, 16:34

  11. Christian Kuhn uploaded patch set 3 05/22/15, 16:58

  12. Christian Kuhn voted on patch set 3 CR +1 V +1 05/22/15, 17:00

  13. Christian Kuhn commented on patch set 3 05/22/15, 17:15

    revamped the patch. it now properly deprecates. let us get this done.
  14. Wouter Wolters voted on patch set 3 V +2 CR +2 05/22/15, 17:42

  15. Wouter Wolters merged patch set 3 05/22/15, 17:42