Review main Merged

37240[TASK] Streamline ext_localconf.php / ext_tables.php of sysexts

Benni Mack CR +2 V +2 Hard +311 −311 updated 02/26/15, 16:26

Commit message

In order to have a proper "way to do things" for extension
developers to look up registration process the following
parts were streamlined:

- Discouraged usage of the pseudo-global variable $_EXTKEY inside
  ext_localconf.php and ext_tables.php in favor of strings.
  For module registrations this part was left out for now as
  module registration will be streamlined separately.
- Use PHP5.5-style ::class in all occurrences instead of escaped
  strings for class names.
- Use $GLOBALS['TYPO3_CONF_VARS'] instead of $TYPO3_CONF_VARS.

Review

  • Code review CR +2
    • Markus Klein +2
    • Christian Kuhn +1
  • Verified V +2
    • Markus Klein +2
    • Christian Kuhn +1

Issues 1

Files 36

Show 16 more files

Review log 9

  1. Benni Mack uploaded patch set 1 02/25/15, 18:33

  2. Markus Klein updated the commit message in patch set 2 02/25/15, 18:53

  3. Markus Klein commented on patch set 2 02/25/15, 19:00

    ext_localconf.php:5

    IMO all those & are not needed
  4. Andreas Kienast commented on patch set 2 02/25/15, 19:21

    Shouldn't we also streamline all ext_emconf.php's?
  5. Christian Kuhn uploaded patch set 3 02/26/15, 15:27

  6. Christian Kuhn commented on patch set 2 02/26/15, 15:27

    ext_localconf.php:5 Reply

    True. Done
  7. Christian Kuhn commented on patch set 3 CR +1 V +1 02/26/15, 15:28

    ext_emconf.php can be done in different patch, patch itself looks fine.
  8. Markus Klein voted on patch set 3 CR +2 V +2 02/26/15, 16:25

  9. Markus Klein merged patch set 3 02/26/15, 16:26