Review main Merged

3728[FEATURE] Change t3d exports default export target directory

Mario Rimann CR +2 V +2 Easy +10 −5 updated 06/03/13, 20:49

Commit message

By default a t3d export ended up in fileadmin/ and the resulting file
was publicly available. This change just changes the default directory
to be fileadmin/_temp_/ which is .htaccess protected and cannot be
accessed from outside.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Susi Moog +1

Issues 1

Files 2

Review log 14

  1. Mario Rimann commented on patch set 1 07/31/11, 12:32

    (1 inline comment)
  2. Steffen Müller commented on patch set 2 07/31/11, 12:32

    Verified; Looks good to me, but someone else must approve
  3. Mario Rimann uploaded patch set 2 07/31/11, 12:32

  4. Stefan Neufeind commented on patch set 2 07/31/11, 12:32

    Verified; Looks good to me, but someone else must approve
  5. Susi Moog commented on patch set 3 07/31/11, 12:32

    Verified; Looks good to me, but someone else must approve
  6. Christian Kuhn commented on patch set 3 V 0 07/31/11, 12:32

    by team member; Looks good to me, approved
  7. Christian Kuhn uploaded patch set 3 07/31/11, 12:32

  8. Christian Kuhn merged patch set 3 07/31/11, 12:32

  9. Georg Ringer commented on patch set 1 07/31/11, 12:32

    Verified; Looks good to me, but someone else must approve

    index.php:1550

    can you adobt CGL > space around the . and maybe cleanup around a bit? space instead of tab?
  10. Georg Ringer commented on patch set 2 V 0 07/31/11, 12:32

    by team member; Looks good to me, approved
  11. Mr. Jenkins commented on patch set 1 07/31/11, 12:32

  12. Mr. Jenkins commented on patch set 2 07/31/11, 12:32

  13. Mr. Jenkins commented on patch set 3 07/31/11, 12:32

  14. Christian Kuhn commented on patch set 3 07/31/11, 12:32

    The latest change set just added a NEWS.txt entry ...