37308[TASK] Add GlobalsUtility class
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 6
-
mostwanted uploaded patch set 1 02/27/15, 07:39
-
mostwanted uploaded patch set 2 02/27/15, 07:40
-
Mathias Brodala commented on patch set 1 CR -1 02/27/15, 07:42
I don't like this approach since this imposes a burden to constantly extend this class with even more getters. One point of the local getter methods is to allow for easy mocking in tests. A class with static methods would revert this again. And in the mid/long term this topic needs to be tackled with dependency injection anyways. -
Wouter Wolters commented on patch set 2 CR -2 02/27/15, 07:43
No, this is not good practice! -
mostwanted abandoned the change 02/27/15, 08:06
-
Andy Grunwald commented on patch set 2 05/15/15, 16:34
Github tests: failure Pull request: https://github.com/typo3-ci/TYPO3.CMS-pre-merge-tests/pull/92