Review main Merged

37328[BUGFIX] Escape regex chars when building sWordRegEx

Alexander Stehlik CR +2 V +2 Normal +80 −11 updated 02/28/15, 18:40

Commit message

The submitted sword_list GET parameters are parsed through
preg_quote() when loaded into  TSFE->sWordRegEx to prevent
invalid regular expressions.

The initialization is moved to a seperate method
PageGenerator::initializeSearchWordDataInTsfe() and unit
tests are added.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Wouter Wolters +1
    • Nicole Hummel +1
  • Verified V +2
    • Anja Leichsenring +2
    • Wouter Wolters +1
    • Nicole Hummel +1

Issues 1

Files 3

Review log 6

  1. Alexander Stehlik uploaded patch set 1 02/27/15, 19:14

  2. Nicole Hummel voted on patch set 1 CR +1 V +1 02/27/15, 19:42

  3. Wouter Wolters voted on patch set 1 CR +1 02/27/15, 22:25

  4. Wouter Wolters commented on patch set 1 V +1 02/27/15, 22:25

    Verified by running Unit-tests
  5. Anja Leichsenring voted on patch set 1 CR +2 V +2 02/28/15, 18:40

  6. Anja Leichsenring merged patch set 1 02/28/15, 18:40