Review main Merged

37373[TASK] Do not respect autoload info if core repo is composer root

Helmut Hummel CR +2 V +2 Easy +8 −6 updated 02/28/15, 20:55

Commit message

Doing a composer install directly in typo3 source has been
a requirement for core development for a while and a convenient shortcut
to quickly set up a TYPO3 installation for executing tests for extensions.

Respecting the class loading information generated in that location is
unfortunate however as it would require editing of the core composer.json
if additional classes from the core should respected.

Instead of respecting this as valid composer autoload file location,
we always fall back to the hard coded and committed class loading info
if no autoload file of a composer distribution call is found.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Helmut Hummel +2

Issues 1

Files 1

Review log 4

  1. Helmut Hummel uploaded patch set 1 02/28/15, 20:33

  2. Christian Kuhn commented on patch set 1 CR +2 02/28/15, 20:40

    +2 on reading - Helmut explained the details to me.
  3. Helmut Hummel voted on patch set 1 V +2 02/28/15, 20:55

  4. Helmut Hummel merged patch set 1 02/28/15, 20:55