Review TYPO3_6-2 Merged

37380[TASK] Do not respect autoload info if core repo is composer root

Helmut Hummel CR +2 V +2 Easy +8 −10 updated 03/13/15, 13:28

Commit message

Doing a composer install directly in typo3 source has been
a requirement for core development for a while and a convenient shortcut
to quickly set up a TYPO3 installation for executing tests for extensions.

Respecting the class loading information generated in that location is
unfortunate however as it would require editing of the core composer.json
if additional classes from the core should respected.

Instead of respecting this as valid composer autoload file location,
we always fall back to the hard coded and committed class loading info
if no autoload file of a composer distribution call is found.

Review

  • Code review CR +2
    • Helmut Hummel +2
  • Verified V +2
    • Helmut Hummel +2

Issues 1

Files 1

Review log 7

  1. Helmut Hummel uploaded patch set 1 02/28/15, 21:23

  2. Helmut Hummel voted on patch set 1 CR +2 V +2 02/28/15, 21:24

  3. Helmut Hummel merged patch set 1 02/28/15, 21:24

  4. Alexander Stehlik commented on patch set 2 03/11/15, 20:49

    After this change the distribution path will never be used, because the fallback path is checked first in the loop. The fallback should be added after the distribution to the array.
  5. Peter Niederlag commented on patch set 2 03/13/15, 13:24

    From reading the code I must second Alexander here, it seems contrib/vendor/autoload.php is checked first and I don't see a use case where it would not be present
  6. Helmut Hummel commented on patch set 2 03/13/15, 13:25

    I have a patch ready in a minute...
  7. Helmut Hummel commented on patch set 2 03/13/15, 13:28

    Here you go: http://review.typo3.org/37819 Sorry for the hassle!