Review main Merged

37398[TASK] Code cleanup RenameFileController.php

Michael Oehlhof CR +2 V +2 Easy +30 −12 updated 03/01/15, 10:52

Commit message

backend/Classes/Controller/File/RenameFileController.php
To get it "green" in PhpStorm several changes are made:

- set correct parameter type in PhpDoc comment
- set correct return type in PhpDoc comment
- add getter for LanguageService
- add getter for DocumentTemplate

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Christian Kuhn +1

Issues 1

Files 2

Review log 4

  1. Michael Oehlhof uploaded patch set 1 03/01/15, 08:09

  2. Christian Kuhn commented on patch set 1 CR +1 V +1 03/01/15, 10:42

    RenameFileController.php:169

    is ok, checked it.
  3. Anja Leichsenring voted on patch set 1 CR +2 V +2 03/01/15, 10:52

  4. Anja Leichsenring merged patch set 1 03/01/15, 10:52