Review main Merged

37404[TASK] Code cleanup: ColorpickerController.php

Michael Oehlhof CR +2 V +2 Easy +19 −11 updated 03/01/15, 14:05

Commit message

backend/classes/Controller/Wizard/ColorpickerController.php
To get it "green" in PhpStorm several changes were made:

- set correct return type in PhpDoc comment
- makeInstance of GraphicalFunctions to call non-static function
  imageCreateFromFile
- change local variable names to lowerCamelCase

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 6

  1. Michael Oehlhof uploaded patch set 1 03/01/15, 12:22

  2. Christian Kuhn commented on patch set 1 03/01/15, 12:35

    ColorpickerController.php:117

    protected

    ColorpickerController.php:384

    destroy call is not needed, imho
  3. Michael Oehlhof uploaded patch set 2 03/01/15, 13:43

  4. Christian Kuhn voted on patch set 2 CR +1 V +1 03/01/15, 13:54

  5. Wouter Wolters voted on patch set 2 V +2 CR +2 03/01/15, 14:05

  6. Wouter Wolters merged patch set 2 03/01/15, 14:05