Review main Merged

37442[BUGFIX] Add variable declaration in TsConfigParser

Michael Oehlhof CR +2 V +2 Easy +7 −0 updated 03/30/15, 13:03

Commit message

In backend/Classes/Configuratio/TsConfigParser.php $this->id is used,
but there was no variable declaration.

Review

  • Code review CR +2
    • Markus Klein +2
  • Verified V +2
    • Markus Klein +2

Issues 1

Files 1

Review log 5

  1. Michael Oehlhof uploaded patch set 1 03/01/15, 23:13

  2. Markus Klein commented on patch set 1 03/29/15, 18:41

    The variable is potentially set from outside, so making it protected would a breaking change
  3. Michael Oehlhof uploaded patch set 2 03/29/15, 22:40

  4. Markus Klein commented on patch set 2 CR +2 V +2 03/30/15, 13:03

    no-brainer now. thanks
  5. Markus Klein merged patch set 2 03/30/15, 13:03