Review main Merged

37443[TASK] Code cleanup ContextMenuConfiguration.php

Michael Oehlhof CR +2 V +2 Easy +2 −1 updated 03/02/15, 16:01

Commit message

backend/Classes/ContextMenu/Pagetree/Extdirect/ContextMenuConfiguration.php
To get it "green" in PhpStorm several changes were made:

- set correct parameter type in PhpDoc comment
- add missing return value

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 1

Review log 5

  1. Michael Oehlhof uploaded patch set 1 03/01/15, 23:27

  2. Christian Kuhn commented on patch set 1 CR -1 03/02/15, 15:59

    ContextMenuConfiguration.php:51

    no else needed ... just initialize it before the if ;)
  3. Christian Kuhn uploaded patch set 2 03/02/15, 16:00

  4. Christian Kuhn voted on patch set 2 CR +2 V +2 03/02/15, 16:01

  5. Christian Kuhn merged patch set 2 03/02/15, 16:01