Review main Merged

37448[TASK] Move RemoveXSS to EXT:core

Benni Mack CR +2 V +2 Easy +11 −15 updated 03/02/15, 11:07

Commit message

The external library RemoveXSS placed
within typo3/contrib/ is moved to EXT:core
and also loaded via composer in order
to avoid a require_once.

Additionally, some other changes in
the static composer class loader shipped
with typo3/contrib/vendor are updated
as well.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1

Issues 1

Files 6

Review log 8

  1. Benni Mack uploaded patch set 1 03/02/15, 10:50

  2. Wouter Wolters commented on patch set 1 V -1 03/02/15, 10:53

    sysext/core/Tests/Legacy/typo3/contrib/class.removexssTest.php 15:require_once(PATH_typo3 . 'contrib/RemoveXSS/RemoveXSS.php');
  3. Wouter Wolters uploaded patch set 2 03/02/15, 10:55

  4. Wouter Wolters voted on patch set 2 V +1 CR +1 03/02/15, 10:56

  5. Markus Klein commented on patch set 2 03/02/15, 11:04

    Why do we need those extra classmaps?
  6. Christian Kuhn voted on patch set 2 V +2 CR +2 03/02/15, 11:04

  7. Christian Kuhn commented on patch set 2 03/02/15, 11:06

    The classmaps are for the composer entry since it does not follow our namespacing. removeXSS will be deprecated in the future anyway and we don't want to move it into core namespace now. should stay separated.
  8. Christian Kuhn merged patch set 2 03/02/15, 11:07