Review main Merged

37455[TASK] Use constants instead of raw bitmask values

Andreas Kienast CR +2 V +2 Hard +202 −81 updated 03/15/15, 17:38

Commit message

The used bitmasks of JsConfirmation and Permission are put
into "enums" and their representing constants are used instead
of the raw bitmask values.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Stefan Neufeind +1
    • Mathias Brodala +1
    • Nicole Hummel +1
  • Verified V +2
    • Frank Nägler +2
    • Nicole Hummel +1

Issues 1

Files 24

Show 4 more files

Review log 33

Show 8 earlier messages
  1. Andreas Kienast uploaded patch set 1 03/02/15, 13:20

  2. Andreas Kienast uploaded patch set 2 03/02/15, 13:26

  3. Mathias Brodala commented on patch set 2 CR -1 03/02/15, 13:37

    Please remove the "Enum" part from the namespace and use the core "Enumeration" class for "JsConfirmation" and "Permission".
  4. Stefan Neufeind commented on patch set 2 CR +1 03/02/15, 13:37

    Great. Double-checked all replacements.
  5. Andreas Kienast uploaded patch set 3 03/02/15, 14:11

  6. Andreas Kienast uploaded patch set 4 03/02/15, 14:38

  7. Andreas Kienast uploaded patch set 5 03/03/15, 06:56

  8. Nicole Hummel commented on patch set 5 CR -1 03/03/15, 15:01

    Clipboard.php:273

    Is this change wanted?

    EditDocumentController.php:861

    Wrong constant

    EditDocumentController.php:862

    wrong constant

    TreeElement.php:119

    missing use statement?!
  1. Stefan Neufeind commented on patch set 5 CR -1 03/03/15, 15:08

    will push an update

    Clipboard.php:273 Reply

    not really

    EditDocumentController.php:861 Reply

    good catch. must be CONTENTEDIT
  2. Andreas Kienast commented on patch set 5 V -1 03/03/15, 15:09

    On it
  3. Andreas Kienast uploaded patch set 6 03/03/15, 15:11

  4. Andreas Kienast commented on patch set 6 03/03/15, 15:12

    Oops, sorry Stefan! I didn't notice you commented and are working on it, too.
  5. Nicole Hummel voted on patch set 6 CR +1 03/03/15, 15:14

  6. Stefan Neufeind voted on patch set 6 CR +1 03/03/15, 15:17

  7. Nicole Hummel commented on patch set 6 CR -1 03/03/15, 15:27

    PageLayoutController.php:19

    Wrong class
  8. Andreas Kienast uploaded patch set 7 03/03/15, 15:33

  9. Nicole Hummel uploaded patch set 8 03/03/15, 18:05

  10. Wouter Wolters commented on patch set 8 03/03/15, 18:07

    JsConfirmation.php:17

    missing class comment

    Permission.php:17

    mssing class comment
  11. Nicole Hummel voted on patch set 8 CR +1 V +1 03/03/15, 18:11

  12. Nicole Hummel uploaded patch set 9 03/03/15, 19:30

  13. Nicole Hummel voted on patch set 9 CR +1 V +1 03/03/15, 19:31

  14. Stefan Neufeind voted on patch set 9 CR +1 03/03/15, 19:34

  15. Mathias Brodala uploaded patch set 10 03/04/15, 07:57

  16. Mathias Brodala uploaded patch set 11 03/04/15, 07:58

  17. Mathias Brodala commented on patch set 11 03/04/15, 07:59

    Slightly more readable constant names, simply changed via search/replace.
  18. Andreas Kienast uploaded patch set 12 03/06/15, 18:04

  19. Nicole Hummel commented on patch set 12 03/06/15, 20:52

    @Andreas you only did a rebase, didn't you?!
  20. Nicole Hummel voted on patch set 12 CR +1 V +1 03/06/15, 20:53

  21. Andreas Kienast commented on patch set 12 03/06/15, 22:01

    Yes, Nicole.
  22. Mathias Brodala voted on patch set 12 CR +1 03/10/15, 14:50

  23. Stefan Neufeind voted on patch set 12 CR +1 03/10/15, 14:55

  24. Frank Nägler commented on patch set 12 V +2 CR +2 03/15/15, 17:38

    After talking to Lolli, it is ok to merge this patch now, it should not conflict with the FormEngine refactoring.
  25. Frank Nägler merged patch set 12 03/15/15, 17:38