37455[TASK] Use constants instead of raw bitmask values
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Stefan Neufeind +1
- Mathias Brodala +1
- Nicole Hummel +1
-
Verified V +2
- Frank Nägler +2
- Nicole Hummel +1
Issues 1
Files 24
- typo3/sysext/backend/Classes/ClickMenu/ClickMenu.php+8 −6
- typo3/sysext/backend/Classes/Clipboard/Clipboard.php2+3 −2
- typo3/sysext/backend/Classes/Controller/Wizard/AbstractWizardController.php+3 −2
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php3+9 −7
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php1+5 −4
- typo3/sysext/backend/Classes/Form/Element/FlexElement.php+2 −1
- typo3/sysext/backend/Classes/Form/Element/InlineElement.php+8 −7
- typo3/sysext/backend/Classes/Form/Element/TreeElement.php1+2 −1
- typo3/sysext/backend/Classes/Form/FormEngine.php+3 −2
- typo3/sysext/backend/Classes/Search/LiveSearch/LiveSearch.php+3 −2
- typo3/sysext/backend/Classes/Tree/Pagetree/ExtdirectTreeDataProvider.php+2 −1
- typo3/sysext/backend/Classes/View/PageLayoutView.php+4 −3
- typo3/sysext/backend/Classes/View/ThumbnailView.php+2 −1
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+16 −20
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+2 −1
- typo3/sysext/core/Classes/FrontendEditing/FrontendEditingController.php+5 −4
- typo3/sysext/core/Classes/Type/Bitmask/JsConfirmation.php1new+46 −0
- typo3/sysext/core/Classes/Type/Bitmask/Permission.php1new+56 −0
- typo3/sysext/feedit/Classes/FrontendEditPanel.php+2 −1
- typo3/sysext/filelist/Classes/FileList.php+2 −1
Review log 33
Show 8 earlier messages
-
Andreas Kienast uploaded patch set 1 03/02/15, 13:20
-
Andreas Kienast uploaded patch set 2 03/02/15, 13:26
-
Mathias Brodala commented on patch set 2 CR -1 03/02/15, 13:37
Please remove the "Enum" part from the namespace and use the core "Enumeration" class for "JsConfirmation" and "Permission". -
Stefan Neufeind commented on patch set 2 CR +1 03/02/15, 13:37
Great. Double-checked all replacements. -
Andreas Kienast uploaded patch set 3 03/02/15, 14:11
-
Andreas Kienast uploaded patch set 4 03/02/15, 14:38
-
Andreas Kienast uploaded patch set 5 03/03/15, 06:56
-
Nicole Hummel commented on patch set 5 CR -1 03/03/15, 15:01
Clipboard.php:273Is this change wanted?EditDocumentController.php:861Wrong constantEditDocumentController.php:862wrong constantTreeElement.php:119missing use statement?!
-
Stefan Neufeind commented on patch set 5 CR -1 03/03/15, 15:08
will push an updateClipboard.php:273Replynot reallyEditDocumentController.php:861Replygood catch. must be CONTENTEDIT -
Andreas Kienast commented on patch set 5 V -1 03/03/15, 15:09
On it -
Andreas Kienast uploaded patch set 6 03/03/15, 15:11
-
Andreas Kienast commented on patch set 6 03/03/15, 15:12
Oops, sorry Stefan! I didn't notice you commented and are working on it, too. -
Nicole Hummel voted on patch set 6 CR +1 03/03/15, 15:14
-
Stefan Neufeind voted on patch set 6 CR +1 03/03/15, 15:17
-
Nicole Hummel commented on patch set 6 CR -1 03/03/15, 15:27
PageLayoutController.php:19Wrong class -
Andreas Kienast uploaded patch set 7 03/03/15, 15:33
-
Nicole Hummel uploaded patch set 8 03/03/15, 18:05
-
Wouter Wolters commented on patch set 8 03/03/15, 18:07
JsConfirmation.php:17missing class commentPermission.php:17mssing class comment -
Nicole Hummel voted on patch set 8 CR +1 V +1 03/03/15, 18:11
-
Nicole Hummel uploaded patch set 9 03/03/15, 19:30
-
Nicole Hummel voted on patch set 9 CR +1 V +1 03/03/15, 19:31
-
Stefan Neufeind voted on patch set 9 CR +1 03/03/15, 19:34
-
Mathias Brodala uploaded patch set 10 03/04/15, 07:57
-
Mathias Brodala uploaded patch set 11 03/04/15, 07:58
-
Mathias Brodala commented on patch set 11 03/04/15, 07:59
Slightly more readable constant names, simply changed via search/replace. -
Andreas Kienast uploaded patch set 12 03/06/15, 18:04
-
Nicole Hummel commented on patch set 12 03/06/15, 20:52
@Andreas you only did a rebase, didn't you?! -
Nicole Hummel voted on patch set 12 CR +1 V +1 03/06/15, 20:53
-
Andreas Kienast commented on patch set 12 03/06/15, 22:01
Yes, Nicole. -
Mathias Brodala voted on patch set 12 CR +1 03/10/15, 14:50
-
Stefan Neufeind voted on patch set 12 CR +1 03/10/15, 14:55
-
Frank Nägler commented on patch set 12 V +2 CR +2 03/15/15, 17:38
After talking to Lolli, it is ok to merge this patch now, it should not conflict with the FormEngine refactoring. -
Frank Nägler merged patch set 12 03/15/15, 17:38