Review main Merged

37479[TASK] Make db_new.php dispatched

Wouter Wolters CR +2 V +2 Normal +98 −23 updated 03/06/15, 10:49

Commit message

Use dispatching for db_new.php

Review

  • Code review CR +2
    • Benni Mack +2
    • Markus Klein +1
  • Verified V +2
    • Benni Mack +2
    • Markus Klein +1

Issues 1

Files 15

Review log 13

  1. Wouter Wolters uploaded patch set 1 03/02/15, 21:44

  2. Wouter Wolters uploaded patch set 2 03/02/15, 22:00

  3. Wouter Wolters uploaded patch set 3 03/03/15, 18:13

  4. Wouter Wolters commented on patch set 3 03/03/15, 18:14

    NewRecordController.php:326

    please take a good look at this change! Somehow this looks already broken in the old situation.
  5. Benni Mack commented on patch set 3 03/04/15, 21:07

    NewRecordController.php:326 Reply

    yeah, I will test this one. maybe we can completely fix it.
  6. Benni Mack uploaded patch set 4 03/06/15, 05:38

  7. Benni Mack voted on patch set 4 CR +1 V +1 03/06/15, 05:40

  8. Georg Ringer voted on patch set 4 CR +1 V +1 03/06/15, 09:15

  9. Markus Klein commented on patch set 4 CR -1 03/06/15, 09:17

    working on this one
  10. Markus Klein uploaded patch set 5 03/06/15, 10:06

  11. Markus Klein voted on patch set 5 CR +1 V +1 03/06/15, 10:06

  12. Benni Mack voted on patch set 5 CR +2 V +2 03/06/15, 10:49

  13. Benni Mack merged patch set 5 03/06/15, 10:49