Review main Merged

37481[BUGFIX] Check folder permission for default upload folder

Nicole Hummel CR +2 V +2 Easy +11 −8 updated 03/25/15, 11:10

Commit message

The default upload folder has to be writable to add new files.
Do not return a default folder if the user does not have add permissions for it.

Review

  • Code review CR +2
    • Helmut Hummel +2
    • Jan Helke +1
    • Frans Saris +1
    • Nicole Hummel +1
  • Verified V +2
    • Markus Klein +2
    • Nicole Hummel +1
    • Helmut Hummel +1

Issues 1

Files 2

Review log 17

  1. Nicole Hummel uploaded patch set 1 03/03/15, 08:26

  2. Markus Klein commented on patch set 1 CR +1 03/03/15, 13:12

    Looks reasonable
  3. Nicole Hummel commented on patch set 1 V -1 03/04/15, 11:57

    Last folder is saved even if not writable. Will push another update
  4. Nicole Hummel uploaded patch set 2 03/04/15, 12:02

  5. Markus Klein commented on patch set 2 CR +1 03/04/15, 13:28

    Even more reasonable ;-)
  6. Andreas Kienast voted on patch set 2 CR +1 03/20/15, 08:02

  7. Frans Saris voted on patch set 2 CR +1 03/20/15, 16:43

  8. Markus Klein commented on patch set 2 03/20/15, 16:44

    Did you read what Bernhard wrote? https://forge.typo3.org/issues/59589#note-27
  9. Helmut Hummel commented on patch set 2 CR -1 03/24/15, 10:30

    have minor nitpicks which I'm going to fix after testing
  10. Helmut Hummel uploaded patch set 3 03/24/15, 11:30

  11. Helmut Hummel voted on patch set 3 CR +2 V +1 03/24/15, 11:31

  12. Nicole Hummel voted on patch set 3 CR +1 V +1 03/24/15, 13:42

  13. Jan Helke voted on patch set 3 CR +1 03/24/15, 14:07

  14. Frans Saris voted on patch set 3 CR +1 03/24/15, 15:58

  15. Markus Klein voted on patch set 3 V +2 03/25/15, 11:09

  16. Markus Klein merged patch set 3 03/25/15, 11:09

  17. Markus Klein commented on patch set 4 03/25/15, 11:10

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit 683a1ff61a14049dda2d17ceecb6d08e7ecaa9b4