Review main Merged

37513[TASK] Code cleanup EXT:backend/Classes/File/*.php

Michael Oehlhof CR +2 V +2 Normal +89 −42 updated 03/04/15, 18:50

Commit message

- add missing return values
- add missing phpdoc comments
- remove unused variable assingments
- add getter for LanguageService
- add getter for BackendUser

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Christian Kuhn +1

Issues 1

Files 4

Review log 9

  1. Michael Oehlhof uploaded patch set 1 03/03/15, 22:59

  2. Michael Oehlhof commented on patch set 1 03/03/15, 23:03

    EditFileController.php ist not "green" because of textarea attribute wrap="off", which is not defined in HTML definition. FileController.php shows 1 warning in the yellow box at the top right of the edit window, but I didn't found the position in source.
  3. Christian Kuhn voted on patch set 1 CR +1 V +1 03/04/15, 10:22

  4. Oliver Klee commented on patch set 1 03/04/15, 11:24

    EditFileController.php:88

    We still need the @return void.
  5. Wouter Wolters commented on patch set 1 03/04/15, 18:30

    FileUploadController.php:149

    fix tabs here
  6. Wouter Wolters uploaded patch set 2 03/04/15, 18:35

  7. Christian Kuhn voted on patch set 2 CR +1 V +1 03/04/15, 18:49

  8. Wouter Wolters voted on patch set 2 V +2 CR +2 03/04/15, 18:50

  9. Wouter Wolters merged patch set 2 03/04/15, 18:50