37513[TASK] Code cleanup EXT:backend/Classes/File/*.php
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Christian Kuhn +1
-
Verified V +2
- Wouter Wolters +2
- Christian Kuhn +1
Issues 1
Files 4
- typo3/sysext/backend/Classes/Controller/File/CreateFolderController.php+27 −17
- typo3/sysext/backend/Classes/Controller/File/EditFileController.php1+31 −11
- typo3/sysext/backend/Classes/Controller/File/FileController.php+11 −3
- typo3/sysext/backend/Classes/Controller/File/FileUploadController.php1+20 −11
Review log 9
-
Michael Oehlhof uploaded patch set 1 03/03/15, 22:59
-
Michael Oehlhof commented on patch set 1 03/03/15, 23:03
EditFileController.php ist not "green" because of textarea attribute wrap="off", which is not defined in HTML definition. FileController.php shows 1 warning in the yellow box at the top right of the edit window, but I didn't found the position in source. -
Christian Kuhn voted on patch set 1 CR +1 V +1 03/04/15, 10:22
-
Oliver Klee commented on patch set 1 03/04/15, 11:24
EditFileController.php:88We still need the @return void. -
Wouter Wolters commented on patch set 1 03/04/15, 18:30
FileUploadController.php:149fix tabs here -
Wouter Wolters uploaded patch set 2 03/04/15, 18:35
-
Christian Kuhn voted on patch set 2 CR +1 V +1 03/04/15, 18:49
-
Wouter Wolters voted on patch set 2 V +2 CR +2 03/04/15, 18:50
-
Wouter Wolters merged patch set 2 03/04/15, 18:50