Review main Merged

37617[TASK] Remove nobr CSS class and nobr tags

Benjamin Kott CR +2 V +2 Easy +20 −29 updated 03/08/15, 22:39

Commit message

Review

  • Code review CR +2
    • Jigal van Hemert +2
  • Verified V +2
    • Jigal van Hemert +2

Issues 1

Files 12

Review log 12

  1. Benjamin Kott uploaded patch set 1 03/07/15, 12:53

  2. Markus Klein commented on patch set 1 V +1 03/07/15, 14:11

    Change is fine, but can we remove the class without breaking extensions?
  3. Benjamin Kott commented on patch set 1 03/07/15, 14:17

    Well, we could always break something when we remove css classes from the core. But we have to in order to get it cleaner. In this case the effect would be marginal. It will not make something unusable.
  4. Markus Klein commented on patch set 1 CR +1 03/07/15, 14:29

    fine with me, you've to know that.
  5. Michael Oehlhof voted on patch set 1 CR +1 V +1 03/07/15, 17:34

  6. Jigal van Hemert voted on patch set 1 CR +2 V +2 03/08/15, 22:11

  7. Gerrit wrote 03/08/15, 22:11

    The change could not be merged due to a path conflict. Please rebase the change locally and upload the rebased commit for review.
  8. Jigal van Hemert uploaded patch set 2 03/08/15, 22:19

  9. Jigal van Hemert voted on patch set 2 CR +2 V +2 03/08/15, 22:19

  10. Jigal van Hemert uploaded patch set 3 03/08/15, 22:38

  11. Jigal van Hemert commented on patch set 3 CR +2 V +2 03/08/15, 22:39

    Rebased locally to solve merge conflict.
  12. Jigal van Hemert merged patch set 3 03/08/15, 22:39