Review main Merged

37618[TASK] Remove unused .typo3-red-background CSS class

Benjamin Kott CR +2 V +2 Easy +0 −7 updated 03/08/15, 21:05

Commit message

Review

  • Code review CR +2
    • Georg Ringer +2
    • Michael Oehlhof +1
  • Verified V +2
    • Georg Ringer +2
    • Michael Oehlhof +1

Issues 1

Files 2

Review log 9

  1. Benjamin Kott uploaded patch set 1 03/07/15, 12:58

  2. Markus Klein commented on patch set 1 03/07/15, 14:08

    Might this be used by some extension?
  3. Benjamin Kott commented on patch set 1 03/07/15, 14:14

    Could be, but the core should not ship css that is used by a single extension. Its already in the deprecated file and we have enough options to mark stuff red.
  4. Markus Klein commented on patch set 1 03/07/15, 14:30

    well, if we take it seriously it is in the deprecated file since version 7, so there has not been a deprecation phase. this is breaking! Why would it hurt to keep such dumb css classes in this deprecated file? The Core must not use deprecated CSS of course.
  5. Benjamin Kott commented on patch set 1 03/07/15, 14:39

    The problem is that the currently have too much css in the backend through the inclusion of the bootstrap framework and other stuff. We have to reduce it drasticly to have a lower number of selectors in the files to keep IE9 for example working correclty.
  6. Georg Ringer commented on patch set 1 V +1 CR +1 03/07/15, 18:36

    it is just css! remove it!
  7. Michael Oehlhof voted on patch set 1 CR +1 V +1 03/08/15, 19:47

  8. Georg Ringer voted on patch set 1 CR +2 V +2 03/08/15, 21:05

  9. Georg Ringer merged patch set 1 03/08/15, 21:05