37652[CLEANUP] EXT:backend/Classes/Wizard/*.php
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Wouter Wolters +1
- Andreas Kienast +1
-
Verified V +2
- Christian Kuhn +2
- Wouter Wolters +1
- Andreas Kienast +1
Issues 1
Files 7
- typo3/sysext/backend/Classes/Controller/Wizard/AbstractWizardController.php+7 −7
- typo3/sysext/backend/Classes/Controller/Wizard/AddController.php5+38 −30
- typo3/sysext/backend/Classes/Controller/Wizard/ColorpickerController.php+8 −7
- typo3/sysext/backend/Classes/Controller/Wizard/EditController.php+38 −37
- typo3/sysext/backend/Classes/Controller/Wizard/ListController.php+2 −2
- typo3/sysext/backend/Classes/Controller/Wizard/RteController.php2+45 −35
- typo3/sysext/backend/Classes/Controller/Wizard/TableController.php22+85 −88
Review log 41
Show 16 earlier messages
-
Michael Oehlhof uploaded patch set 1 03/08/15, 21:33
-
Markus Klein commented on patch set 1 03/08/15, 21:47
-
Michael Oehlhof uploaded patch set 2 03/09/15, 06:04
-
Michael Oehlhof commented on patch set 2 03/09/15, 06:05
Sorry, I interchanged the for parameters and forgot to remove the increment from the code. -
Markus Klein commented on patch set 2 03/10/15, 20:51
will push an updateTableController.php:354$a !== 1 thenTableController.php:355instead of having $a +1 everywhere, lets simply start with 1 and run until $a <= $colsTableController.php:392why that space?TableController.php:537$valueATableController.php:537as $valueBTableController.php:538$valueB -
Markus Klein uploaded patch set 3 03/10/15, 20:57
-
Markus Klein voted on patch set 3 CR +1 V +1 03/10/15, 20:58
-
Michael Oehlhof voted on patch set 3 CR +1 V +1 03/10/15, 21:52
-
Nicole Hummel commented on patch set 3 03/14/15, 12:18
TableController.php:395space not needed -
Stephan Großberndt commented on patch set 3 03/14/15, 12:24
TableController.php:395Replyalso either one string or if concatenating then in multiple lines instead of one -
Stephan Großberndt commented on patch set 3 03/14/15, 12:25
I'll push an update. -
Stephan Großberndt uploaded patch set 4 03/14/15, 13:53
-
Markus Klein voted on patch set 4 CR +1 V +1 03/14/15, 13:59
-
Michael Oehlhof commented on patch set 4 03/14/15, 16:18
Some comments added.TableController.php:268This variable is deprecated, should we remove it then?TableController.php:392My PhpStorm shows a warning here. Attribute EXTERNAL_FRAGMENT is not allowed here (at line 392) If I insert a space then PhpStorm went green. Maybe my PhpStorm is configured different from yours. -
Stephan Großberndt commented on patch set 4 CR +1 03/14/15, 17:26
stripslashes has to be set to false explicitly until it has been removed. regardless of phpstorms warning there will be an space in excess if it is added. -
Markus Klein commented on patch set 4 03/14/15, 18:27
TableController.php:268ReplyNo we can't! The default is TRUE, but we need it FALSE! Please read the deprecation notice for this property, it's a very special case.TableController.php:392ReplyNo, it shows the same for me, but it does not recognize that things are ok. more a bug of phpstorm I'd say.
-
Stephan Großberndt commented on patch set 4 03/15/15, 10:10
-
Christian Kuhn commented on patch set 4 CR -1 03/15/15, 15:12
please please please, do not merge this now. i'm in a heavy code refactoring of the form stuff at the moment basically touching lots of stuff within ext:backend. It would be very nice to not do cleanups here currently since this could easily end up in merge hell for me and I'm really moving tons of stuff with lots of spent hours on it around. -
Frank Nägler commented on patch set 4 CR -1 03/15/15, 15:14
many thanks for your work. At the moment Lolli is working on a big refactoring of FormEngine. Any changes in this area could end in a big rebase-session. For this reason, we should wait with patches in FormEngine until Lolli has finished the refactoring. I will remove my vote later, please wait some days. -
Michael Oehlhof uploaded patch set 5 04/28/15, 20:32
-
Markus Klein commented on patch set 5 05/02/15, 13:17
needs a rebase -
Michael Oehlhof uploaded patch set 6 05/02/15, 16:26
-
Stephan Großberndt voted on patch set 6 CR +1 05/02/15, 16:36
-
Markus Klein updated the commit message in patch set 7 05/02/15, 16:40
-
Christian Kuhn commented on patch set 6 05/02/15, 16:47
RteController.php:142there is no real point in having those getter methods for casual classes: For stuff like typo3_db this is thought as a wrapper around globals to have proper type hinting, always having a wrapper around makeInstance is only useful if you need that for unit tests. ... we can keep that for now, but please don't just do everywhere ... -
Christian Kuhn commented on patch set 7 CR +1 05/02/15, 16:47
@michael, please consider my comment on patch set 7 ... can be kept, though ... -
Markus Klein commented on patch set 7 05/02/15, 16:51
some more thingsAddController.php:124"use" that one tooAddController.php:131move the assignment out of the if.AddController.php:157put that line into the getterRteController.php:143where does that line come from?TableController.php:49Is this really an int?TableController.php:55line-basedTableController.php:449actually StringUtility::beginsWithTableController.php:486same here -
Michael Oehlhof uploaded patch set 8 05/02/15, 17:34
-
Markus Klein commented on patch set 8 05/02/15, 17:54
TableController.php:53This is a bool! Please change that here as well. -
Christian Kuhn uploaded patch set 9 05/03/15, 09:40
-
Christian Kuhn voted on patch set 9 CR +1 V +1 05/03/15, 09:45
-
Andreas Kienast commented on patch set 9 05/03/15, 09:56
AddController.php:131=== -
Andreas Kienast commented on patch set 9 05/03/15, 09:58
TableController.php:328!==TableController.php:334!== -
Wouter Wolters commented on patch set 9 05/03/15, 10:07
AddController.php:131ReplyDoneTableController.php:328ReplyDoneTableController.php:334ReplyDone -
Wouter Wolters uploaded patch set 10 05/03/15, 10:08
-
Wouter Wolters voted on patch set 10 V +1 CR +1 05/03/15, 10:09
-
Andreas Kienast uploaded patch set 11 05/03/15, 10:22
-
Andreas Kienast voted on patch set 11 CR +1 V +1 05/03/15, 10:23
-
Wouter Wolters voted on patch set 11 V +1 CR +1 05/03/15, 10:23
-
Christian Kuhn voted on patch set 11 CR +2 V +2 05/03/15, 10:45
-
Christian Kuhn merged patch set 11 05/03/15, 10:45
TableController.php:352